-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: update binance api positionRisk to v3 #1783
Conversation
Hi @anywhy, This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development. This pull request may get 248 BBG. To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:
Once this pull request is merged, your BBG tokens will be transferred to your wallet. -- Best, |
IsolatedWallet string `json:"isolatedWallet"` | ||
InitialMargin fixedpoint.Value `json:"initialMargin"` | ||
MaintMargin fixedpoint.Value `json:"maintMargin"` | ||
PositionInitialMargin fixedpoint.Value `json:"positionInitialMargin"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make it aligned with the original field, so the diff could be more clean
the field name matters, so please check the field name is matched with the original name
build failed |
Re-estimated karma: this pull request may get 268 BBG |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1783 +/- ##
==========================================
- Coverage 24.11% 23.90% -0.22%
==========================================
Files 617 623 +6
Lines 37569 38170 +601
==========================================
+ Hits 9060 9123 +63
- Misses 27711 28251 +540
+ Partials 798 796 -2
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Re-estimated karma: this pull request may get 288 BBG |
@anywhy can you avoid the merge point? thanks, better to use git rebase rather than "merge" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please put the fields in the original order, thanks
IsolatedWallet string `json:"isolatedWallet"` | ||
InitialMargin fixedpoint.Value `json:"initialMargin"` | ||
MaintMargin fixedpoint.Value `json:"maintMargin"` | ||
PositionInitialMargin fixedpoint.Value `json:"positionInitialMargin"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anywhy please don't change the order of the field, it is hard to review the difference
No description provided.