REFACTOR: Extract and move FeeBudget from xgap #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbearXD
approved these changes
Jun 18, 2024
c9s
reviewed
Jun 18, 2024
| } | ||
|
|
||
| func (s *State) IsOver24Hours() bool { | ||
| return time.Since(s.AccumulatedFeeStartedAt) >= 24*time.Hour |
There was a problem hiding this comment.
can we move this to util? it seems like we use it a lot
There was a problem hiding this comment.
like this https://github.com/c9s/bbgo/pull/1658/files?
c9s
reviewed
Jun 18, 2024
c9s
reviewed
Jun 18, 2024
c9s
approved these changes
Jun 18, 2024
narumiruna
force-pushed
the
narumi/fee-budget
branch
2 times, most recently
from
892c607 to
9e5b202
Compare
narumiruna
force-pushed
the
narumi/fee-budget
branch
from
9e5b202 to
9cbf8a0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
+ Coverage 22.71% 22.75% +0.03%
==========================================
Files 619 622 +3
Lines 44697 44783 +86
==========================================
+ Hits 10153 10189 +36
- Misses 33810 33855 +45
- Partials 734 739 +5
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.