Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: [rebalance] add balance type #1550

Merged
merged 1 commit into from
Mar 4, 2024
Merged

FEATURE: [rebalance] add balance type #1550

merged 1 commit into from
Mar 4, 2024

Conversation

narumiruna
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @narumiruna, This pull request may get 295 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 312 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 327 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 310 BBG

@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 21.74%. Comparing base (449c0ab) to head (3ef7d3e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
- Coverage   21.76%   21.74%   -0.02%     
==========================================
  Files         608      609       +1     
  Lines       44020    44046      +26     
==========================================
  Hits         9579     9579              
- Misses      33759    33785      +26     
  Partials      682      682
Files Coverage Δ
pkg/types/price_type.go 0.00% <0.00%> (ø)
pkg/types/balance_type.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449c0ab...3ef7d3e. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 326 BBG

@narumiruna narumiruna changed the title WIP: FEATURE: [rebalance] add balance type FEATURE: [rebalance] add balance type Mar 1, 2024
c9s
c9s reviewed Mar 4, 2024
View reviewed changes
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 333 BBG

@narumiruna narumiruna force-pushed the narumi/balance-type branch from 6a2ce82 to 75d856b Compare March 4, 2024 09:35
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 350 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 364 BBG

@narumiruna narumiruna force-pushed the narumi/balance-type branch from 4c7471c to 3ef7d3e Compare March 4, 2024 11:58
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 369 BBG

@narumiruna narumiruna enabled auto-merge March 4, 2024 11:59
@narumiruna narumiruna merged commit 3e087e8 into main Mar 4, 2024
3 checks passed
@narumiruna narumiruna deleted the narumi/balance-type branch March 4, 2024 12:09
@bbgokarma-bot
Copy link

Hi @narumiruna,

Well done! 374 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xc87da5b986a646889e84f1cab2cb66cc2d56dd4a71e4f26b6d2e18b6a716ced4

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@ycdesu ycdesu Awaiting requested review from ycdesu

@kbearXD kbearXD Awaiting requested review from kbearXD

@gx578007 gx578007 Awaiting requested review from gx578007

@bailantaotao bailantaotao Awaiting requested review from bailantaotao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narumiruna @bbgokarma-bot @c9s