-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: [bitget] batch subscribe channel #1544
Conversation
Welcome back! @bailantaotao, This pull request may get 246 BBG. |
pkg/exchange/bitget/stream.go
Outdated
logger.WithError(err).Error("failed to send request") | ||
return err | ||
|
||
maximum := 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this to batchSize?
}); err != nil { | ||
logger.WithError(err).Error("failed to send request") | ||
return err | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this part a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it in the next PR
5d3c2d6
to
3a18edd
Compare
Re-estimated karma: this pull request may get 271 BBG |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 21.77% 21.76% -0.01%
==========================================
Files 606 606
Lines 43940 43948 +8
==========================================
Hits 9566 9566
- Misses 33692 33700 +8
Partials 682 682
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hi @bailantaotao, Well done! 291 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x8ca7d43c28aff1b7e1246fdfffd5dc687d1c9f031a13ef6bf581fca2507aa056 Thank you for your contribution! |
No description provided.