Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [bitget] batch subscribe channel #1544

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 246 BBG.

@bailantaotao bailantaotao changed the title FEATURE: [bitget] batch subscribe channel FIX: [bitget] batch subscribe channel Feb 23, 2024
logger.WithError(err).Error("failed to send request")
return err

maximum := 10
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to batchSize?

}); err != nil {
logger.WithError(err).Error("failed to send request")
return err
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this part a function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it in the next PR

@bailantaotao bailantaotao force-pushed the edwin/bitget/batch-subscribe branch from 5d3c2d6 to 3a18edd Compare February 23, 2024 07:49
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 271 BBG

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 21.76%. Comparing base (06c533f) to head (3a18edd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
- Coverage   21.77%   21.76%   -0.01%     
==========================================
  Files         606      606              
  Lines       43940    43948       +8     
==========================================
  Hits         9566     9566              
- Misses      33692    33700       +8     
  Partials      682      682              
Files Coverage Δ
pkg/exchange/bitget/stream.go 20.78% <0.00%> (-0.52%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c533f...3a18edd. Read the comment docs.

@bailantaotao bailantaotao merged commit d0ed34c into main Feb 23, 2024
3 of 5 checks passed
@bailantaotao bailantaotao deleted the edwin/bitget/batch-subscribe branch February 23, 2024 08:07
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 291 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x8ca7d43c28aff1b7e1246fdfffd5dc687d1c9f031a13ef6bf581fca2507aa056

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants