FIX: [retry] fix and improve QueryOrderUntilFilled status check #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @c9s, This pull request may get 206 BBG. |
narumiruna
approved these changes
Feb 21, 2024
kbearXD
reviewed
Feb 21, 2024
| @@ -54,15 +53,17 @@ func QueryOrderUntilFilled( | |||
| OrderID: strconv.FormatUint(orderId, 10), | |||
| }) | |||
|
|
|||
| if err2 != nil || o == nil { | |||
| if err2 != nil { | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
=======================================
Coverage 21.77% 21.77%
=======================================
Files 606 606
Lines 43939 43939
=======================================
Hits 9566 9566
Misses 33691 33691
Partials 682 682 Continue to review full report in Codecov by Sentry.
|
|
Hi @c9s, Well done! 226 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x15617627bcb56adca719cb9038ae01d03955af2d24e3524f12433d1c279a4efb Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.