Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: [okx] generate account info request by requestgen #1493

Merged
merged 2 commits into from
Jan 9, 2024
Merged

FEATURE: [okx] generate account info request by requestgen #1493

merged 2 commits into from
Jan 9, 2024

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 484 BBG.

c9s
c9s reviewed Jan 9, 2024
View reviewed changes
pkg/exchange/okex/okexapi/get_account_info_request.go Outdated

type Account struct {
TotalEquityInUSD fixedpoint.Value `json:"totalEq"`
UpdateTime string `json:"uTime"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

millisecond timestamp here?

Base automatically changed from edwin/okx/refactor-tickers to main January 9, 2024 07:38
@bailantaotao bailantaotao force-pushed the edwin/okx/refactor-account branch from adb9480 to c5e3ca3 Compare January 9, 2024 07:40
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 499 BBG

@bailantaotao bailantaotao force-pushed the edwin/okx/refactor-account branch from c5e3ca3 to 9297293 Compare January 9, 2024 07:59
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 509 BBG

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (c2e3fed) 21.60% compared to head (9297293) 21.61%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage   21.60%   21.61%           
=======================================
  Files         601      602    +1     
  Lines       44098    44081   -17     
=======================================
  Hits         9527     9527           
+ Misses      33876    33859   -17     
  Partials      695      695
Files Coverage Δ
pkg/exchange/okex/okexapi/client.go 11.50% <ø> (+1.87%) ⬆️
.../exchange/okex/okexapi/get_account_info_request.go 0.00% <0.00%> (ø)
pkg/exchange/okex/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e3fed...9297293. Read the comment docs.

@bailantaotao bailantaotao merged commit 08fa1e9 into main Jan 9, 2024
3 of 4 checks passed
@bailantaotao bailantaotao deleted the edwin/okx/refactor-account branch January 9, 2024 08:10
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 519 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x617de0199c3fb31e0fad3aa3d6596a25ebf83b26fee17d7bbea36ef76014d40f

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@ycdesu ycdesu Awaiting requested review from ycdesu

@kbearXD kbearXD Awaiting requested review from kbearXD

@gx578007 gx578007 Awaiting requested review from gx578007

@narumiruna narumiruna Awaiting requested review from narumiruna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bailantaotao @bbgokarma-bot @c9s