fix: skip test when run in github action

c9s · Mar 12, 2024 · 8268ac1 · 8268ac1
1 parent d4eef3e
commit 8268ac1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -20,6 +20,7 @@ jobs:
         go-version:
         - "1.20"
     env:
+      GITHUB_CI: true
       MYSQL_DATABASE: bbgo
       MYSQL_USER: "root"
       MYSQL_PASSWORD: "root" # pragma: allowlist secret

diff --git a/pkg/exchange/binance/exchange_test.go b/pkg/exchange/binance/exchange_test.go
@@ -2,6 +2,7 @@ package binance
 
 import (
 	"context"
+	"os"
 	"strings"
 	"testing"
 
@@ -22,6 +23,12 @@ func Test_new(t *testing.T) {
 	assert.NotEmpty(t, ex)
 	ctx := context.Background()
 	ticker, err := ex.QueryTicker(ctx, "btcusdt")
-	assert.NotEmpty(t, ticker)
-	assert.NoError(t, err)
+	if len(os.Getenv("GITHUB_CI")) > 0 {
+		// Github action runs in the US, and therefore binance api is not accessible
+		assert.Empty(t, ticker)
+		assert.Error(t, err)
+	} else {
+		assert.NotEmpty(t, ticker)
+		assert.NoError(t, err)
+	}
 }