Merge pull request #1525 from c9s/edwin/binance-update-api-changes-3

FEATURE: [binance] add margin request

pkg/exchange/binance/binanceapi/client_test.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 
+	"github.com/c9s/bbgo/pkg/fixedpoint"
 	"github.com/c9s/bbgo/pkg/testutil"
 )
 
@@ -168,7 +169,6 @@ func TestClient_NewTransferAssetRequest(t *testing.T) {
 	req.FromSymbol("BTCUSDT")
 	req.ToSymbol("BTCUSDT")
 	req.Amount("0.01")
-	req.Timestamp(time.Now())
 	req.TransferType(TransferAssetTypeIsolatedMarginToMain)
 	res, err := req.Do(ctx)
 	assert.NoError(t, err)
@@ -197,3 +197,50 @@ func TestClient_GetMarginBorrowRepayHistoryRequest(t *testing.T) {
 	assert.NotEmpty(t, res)
 	t.Logf("result: %+v", res)
 }
+
+func TestClient_NewPlaceMarginOrderRequest(t *testing.T) {
+	client := getTestClientOrSkip(t)
+	ctx := context.Background()
+
+	err := client.SetTimeOffsetFromServer(ctx)
+	assert.NoError(t, err)
+
+	res, err := client.NewPlaceMarginOrderRequest().
+		Asset("USDT").
+		Amount(fixedpoint.NewFromFloat(5)).
+		IsIsolated(true).
+		Symbol("BNBUSDT").
+		SetBorrowRepayType(BorrowRepayTypeBorrow).
+		Do(ctx)
+	assert.NoError(t, err)
+	assert.NotNil(t, res)
+	assert.NotEmpty(t, res)
+	t.Logf("result: %+v", res)
+
+	<-time.After(time.Second)
+	end := time.Now()
+	start := end.Add(-24 * time.Hour * 30)
+	histories, err := client.NewGetMarginBorrowRepayHistoryRequest().
+		StartTime(start).
+		EndTime(end).
+		Asset("BNB").
+		IsolatedSymbol("BNBUSDT").
+		SetBorrowRepayType(BorrowRepayTypeBorrow).
+		Do(ctx)
+	assert.NoError(t, err)
+	assert.NotNil(t, histories)
+	assert.NotEmpty(t, histories)
+	t.Logf("result: %+v", histories)
+
+	res, err = client.NewPlaceMarginOrderRequest().
+		Asset("USDT").
+		Amount(fixedpoint.NewFromFloat(5)).
+		IsIsolated(true).
+		Symbol("BNBUSDT").
+		SetBorrowRepayType(BorrowRepayTypeRepay).
+		Do(ctx)
+	assert.NoError(t, err)
+	assert.NotNil(t, res)
+	assert.NotEmpty(t, res)
+	t.Logf("result: %+v", res)
+}

pkg/exchange/binance/binanceapi/place_margin_order_request.go

@@ -0,0 +1,28 @@
+package binanceapi
+
+import (
+	"github.com/c9s/requestgen"
+
+	"github.com/c9s/bbgo/pkg/fixedpoint"
+)
+
+//go:generate requestgen -method POST -url "/sapi/v1/margin/borrow-repay" -type PlaceMarginOrderRequest -responseType .TransferResponse
+type PlaceMarginOrderRequest struct {
+	client requestgen.AuthenticatedAPIClient
+
+	asset string `param:"asset"`
+
+	// TRUE for Isolated Margin, FALSE for Cross Margin, Default FALSE
+	isIsolated bool `param:"isIsolated"`
+
+	// Only for Isolated margin
+	symbol *string `param:"symbol"`
+
+	amount fixedpoint.Value `param:"amount"`
+
+	BorrowRepayType BorrowRepayType `param:"type"`
+}
+
+func (c *RestClient) NewPlaceMarginOrderRequest() *PlaceMarginOrderRequest {
+	return &PlaceMarginOrderRequest{client: c}
+}

pkg/exchange/binance/binanceapi/transfer_asset_request.go

@@ -1,8 +1,6 @@
 package binanceapi
 
 import (
-	"time"
-
 	"github.com/c9s/requestgen"
 )
 
@@ -29,8 +27,6 @@ type TransferAssetRequest struct {
 
 	amount string `param:"amount"`
 
-	timestamp time.Time `param:"timestamp,milliseconds,query"`
-
 	fromSymbol *string `param:"fromSymbol"`
 	toSymbol   *string `param:"toSymbol"`
 }