fix: use size of Base64-encoded ID to calculate ballot length for decryption #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To calculate the ballot length to construct the El Gamal pairs for decryption, currently the decoded ID is used. However, since the ID arrives encoded from the frontend, the length of the Base64-encoded needs to be used instead.
Also fixes the related tests that assumed that the ID was stored in Base64-encoded form when it is not (see e.g.
d-voting/contracts/evoting/types/ballots.go
Line 76 in 0ce24ab
Also cleaned up the comments and cleaned up the code around the calculation of the ballot's size to make it more clear.
This resolves #167 .
Some more details: