Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over styles fixing the layout issues #150

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Copy over styles fixing the layout issues #150

merged 1 commit into from
Oct 16, 2022

Conversation

nmathew98
Copy link
Contributor

Describe your changes

Issue: #117

The layout issues were caused by missing styles as a result of creating a portal, copy them over

Checklist before requesting a review

  • I have performed a self-review of my code.

  • Followed the repository's Contributing Guidelines.

  • I ran the app and tested it locally to verify that it works as expected.

  • I have starred the repository.

@nmathew98
Copy link
Contributor Author

@devarshishimpi

@nmathew98
Copy link
Contributor Author

Didn't use the NewWindow package because of rmariuzzo/react-new-window#130

@MrKrishnaAgarwal MrKrishnaAgarwal added this to the v2.0-roadmap milestone Oct 16, 2022
@MrKrishnaAgarwal MrKrishnaAgarwal added the v2.0-roadmap Version 2.0 Roadmap label Oct 16, 2022
@devarshishimpi devarshishimpi merged commit d71a87b into bytemakers:main Oct 16, 2022
@devarshishimpi devarshishimpi added bug Something isn't working hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted hacktoberfest2022 Hacktoberfest 2022 labels Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Hacktoberfest hacktoberfest2022 Hacktoberfest 2022 hacktoberfest-accepted Hacktoberfest Accepted v2.0-roadmap Version 2.0 Roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants