Add TableEvictType & TableReader::ForceEvict #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mm304321141
force-pushed
the
feature-block-cache-evict
branch
6 times, most recently
from
9104e02 to
3ddc482
Compare
mm304321141
force-pushed
the
feature-block-cache-evict
branch
2 times, most recently
from
8f154e5 to
4bddc46
Compare
mm304321141
force-pushed
the
feature-block-cache-evict
branch
3 times, most recently
from
dd272aa to
d8fe7a5
Compare
Fix db_bench
mm304321141
force-pushed
the
feature-block-cache-evict
branch
8 times, most recently
from
73e1134 to
599010d
Compare
mm304321141
force-pushed
the
feature-block-cache-evict
branch
from
599010d to
6ed45ab
Compare
Layamon
reviewed
Feb 23, 2022
table/block_based_table_reader.cc
Outdated
| iiter.reset(); | ||
|
|
||
| // IndexBlock | ||
| do_evict(rep_->dummy_index_reader_offset); |
There was a problem hiding this comment.
对于partitioned index，如果其CacheDependencies了，好像这些Dependencies没处理？
There was a problem hiding this comment.
是的，DataBlock 是大头，先清理了，这部分还要再看看怎么搞
royguo
reviewed
Feb 23, 2022
| @@ -99,6 +99,8 @@ class TableReader { | |||
| bool (*callback_func)(void* arg, const Slice& key, | |||
| LazyBuffer&& value)); | |||
|
|
|||
| virtual Status ForceEvict() { return Status::NotSupported(); } | |||
There was a problem hiding this comment.
Do you think we should comment on all virtual functions like others in this file? So we could understand what is the purposes of this ForceEvict() without reading through the callstack.
royguo
reviewed
Feb 23, 2022
tools/db_bench_tool.cc
Outdated
| @@ -528,6 +524,8 @@ DEFINE_bool(new_table_reader_for_compaction_inputs, true, | |||
|
|
|||
| DEFINE_int32(compaction_readahead_size, 0, "Compaction readahead size"); | |||
|
|
|||
| DEFINE_int32(table_evict_type, 0, "Table evict type"); | |||
There was a problem hiding this comment.
Maybe we should provide a description of the potential options here
oujiaxin
reviewed
Feb 24, 2022
mm304321141
force-pushed
the
feature-block-cache-evict
branch
2 times, most recently
from
ee337bb to
b382632
Compare
mm304321141
force-pushed
the
feature-block-cache-evict
branch
from
b382632 to
7035f41
Compare
mm304321141
force-pushed
the
feature-block-cache-evict
branch
2 times, most recently
from
248ba01 to
363f0e5
Compare
Fix close db slowly when force evict disabled
mm304321141
force-pushed
the
feature-block-cache-evict
branch
5 times, most recently
from
b8f14cd to
3e98c11
Compare
mm304321141
force-pushed
the
feature-block-cache-evict
branch
from
3e98c11 to
ae369bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.