c#: Add cli option to generate Result types #1115
Conversation
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
use-results
branch
from
9e0e77c to
d77a265
Compare
|
|
||
| /// Generates code for wit Result types instead of exceptions | ||
| #[cfg_attr(feature = "clap", arg(long))] | ||
| pub with_wit_results: bool, |
There was a problem hiding this comment.
open to name suggestions
| @@ -30,6 +30,10 @@ pub struct Opts { | |||
| /// Skip generating `cabi_realloc`, `WasmImportLinkageAttribute`, and component type files | |||
| #[cfg_attr(feature = "clap", arg(long))] | |||
| pub skip_support_files: bool, | |||
|
|
|||
| /// Generates code for wit Result types instead of exceptions | |||
There was a problem hiding this comment.
| /// Generates code for wit Result types instead of exceptions | |
| /// Generate code for WIT `Result` types instead of exceptions |
| var result = imports.test.results.TestInterop.EnumError(a); | ||
| if (result.IsOk) { | ||
| return Result<float, ITest.E>.Ok(result.AsOk); | ||
| }else{ |
There was a problem hiding this comment.
| }else{ | |
| } else { |
| uwrite!( | ||
| self.src, | ||
| "\ | ||
| if ({previous}.IsOk) {{ |
There was a problem hiding this comment.
Nit: Would you mind adjusting the indentation for this and the other uwrite expressions that follow? E.g. put the if under the " on the previous line or similar and indent the var on the next line four columns past that, etc. It's a bit jarring to see it indented way to the right.
| }} else {{ | ||
| throw new {exception_name}({var_name}.AsErr!, {level}); | ||
| }} |
There was a problem hiding this comment.
| }} else {{ | |
| throw new {exception_name}({var_name}.AsErr!, {level}); | |
| }} | |
| }} | |
| else | |
| {{ | |
| throw new {exception_name}({var_name}.AsErr!, {level}); | |
| }} |
| uwrite!( | ||
| self.src, | ||
| "\ | ||
| if ({previous}.IsOk) {{ |
There was a problem hiding this comment.
For the C# I think we are trying to go more the style of { on the next line.
There was a problem hiding this comment.
| if ({previous}.IsOk) {{ | |
| if ({previous}.IsOk) | |
| {{ |
| let tail = oks.iter().map(|_| ")").collect::<Vec<_>>().concat(); | ||
| cases.push(format!( | ||
| "\ | ||
| case {index}: {{ |
There was a problem hiding this comment.
| case {index}: {{ | |
| case {index}: | |
| {{ |
| payload_is_void = result.ok.is_none(); | ||
| } | ||
| if !self.results.is_empty() { | ||
| self.src.push_str("try {\n"); |
There was a problem hiding this comment.
| self.src.push_str("try {\n"); | |
| self.src.push_str(\" | |
| try | |
| {\n"); |
Not sure I've got the rust syntax right here.
| let cases = cases.join("\n"); | ||
| uwriteln!( | ||
| self.src, | ||
| r#"}} catch (WitException e) {{ |
There was a problem hiding this comment.
| r#"}} catch (WitException e) {{ | |
| r#"}} | |
| catch (WitException e) | |
| {{ |
| uwriteln!( | ||
| self.src, | ||
| r#"}} catch (WitException e) {{ | ||
| switch (e.NestingLevel) {{ |
There was a problem hiding this comment.
| switch (e.NestingLevel) {{ | |
| switch (e.NestingLevel) | |
| {{ |
Adds option to generate Result types instead of handling Results via Exceptions: #1042