Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable shrunk memory by default and add related configurations #4008

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable shrunk memory by default and add related configurations #4008

wants to merge 3 commits into from

Conversation

lum1n0us
Copy link
Collaborator

@lum1n0us lum1n0us commented Jan 6, 2025

  • config shrunk memory (in wasm_loader.c) with WAMR_BUILD_SHRUNK_MEMORY
  • update to commit "Dec 20, 2024. Use WPT version of test harness for HTML core test conversion (Quit if meeting unimport globals #1859)" of wasm spec test

loganek
loganek reviewed Jan 6, 2025
View reviewed changes
build-scripts/config_common.cmake
@@ -162,6 +162,11 @@ if (WAMR_BUILD_LINUX_PERF EQUAL 1)
endif ()
endif ()

if (NOT DEFINED WAMR_BUILD_SHRUNK_MEMORY)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we're adding a new build options, I think it'd be good to have a relevant documentation in one of the markdown files too. Could you add it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made updates. Please let me know if you have any further comments.

@lum1n0us lum1n0us force-pushed the fix/config_shrunk_memory branch from d187f67 to dca3f9f Compare January 7, 2025 13:16
@lum1n0us lum1n0us force-pushed the fix/config_shrunk_memory branch from dca3f9f to 99b78f0 Compare January 9, 2025 05:34
@lum1n0us lum1n0us mentioned this pull request Jan 9, 2025
Open
xujuntwt95329
xujuntwt95329 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xujuntwt95329 xujuntwt95329 xujuntwt95329 approved these changes

@no1wudi no1wudi no1wudi approved these changes

@loganek loganek loganek approved these changes

@TianlongLiang TianlongLiang Awaiting requested review from TianlongLiang TianlongLiang is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lum1n0us @loganek @no1wudi @xujuntwt95329