Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console.log redirect to stderr #873

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Changes the default Javy plugin to use the default javy crate setting of false for redirecting console.log to the standard error stream and removes the redirect-stdout-to-stderr configuration option from the default plugin and the CLI. So console.log now writes to standard output.

Why am I making this change?

The behaviour of writing console.log to standard error is unusual and users found it confusing. If someone wants to have console.log write to standard error, they can use a Javy plugin to get that behaviour.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-plugin do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles merged commit 1fa4f05 into main Jan 8, 2025
4 checks passed
@jeffcharles jeffcharles deleted the jc.remove-console-log-redirect branch January 8, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants