wit/bindgen: fix wasm-tools WIT generation bugs #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors from
wasm-tools
were being silently swallowed, masking a number of related issues:import foo:foo/flags
were not being escaped (foo:foo/%flags
).wasm-tools
invocations (in wasm) were being silently ignored. They are now logged and returned. Errors returned fromwasm-tools component embed
are now fatal.wit/bindgen
now supply a logger toGo()
.The synthetic world now uses the original WIT package, to allow inline
import foo: interface { ... }
with inlineuse
statements that refer to other interfaces or worlds in the same package.Fixes #281.