Build gpu code with build tags and add Dockerfile #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
reviewed
Jul 18, 2024
|
|
||
| var _ encoding.Prover = &Prover{} | ||
|
|
||
| func NewProver(config *kzg.KzgConfig, loadG2Points bool) (*Prover, error) { |
There was a problem hiding this comment.
would be good if we don't duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change will make it so we can build the gpu and cpu components separately. So building the gpu code will require specifying the tag
go build -tags gpu -o ./bin/server ./cmd/encoder. Results in some duplicate code but it's worth it for now to maintain the compatibility with the former cpu only builds.Checks