fix: OP_DEFINE_GLOBAL doesn't always add global at the end of the list

buzz-language · Nov 20, 2024 · 618ba9a · 618ba9a
1 parent 20324b3
commit 618ba9a
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/vm.zig b/src/vm.zig
@@ -1031,11 +1031,15 @@ pub const VM = struct {
     }
 
     fn OP_DEFINE_GLOBAL(self: *Self, _: *CallFrame, _: u32, _: OpCode, arg: u24) void {
-        self.globals.ensureTotalCapacity(arg + 1) catch {
+        const new_len = @max(arg + 1, self.globals.items.len);
+
+        self.globals.ensureTotalCapacity(new_len) catch {
             self.panic("Out of memory");
             unreachable;
         };
-        self.globals.items.len = arg + 1;
+
+        // We don't always define a new global at the end of the list
+        self.globals.items.len = new_len;
         self.globals.items[arg] = self.peek(0);
 
         self.globals_count = @max(self.globals_count, arg);