Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering of MIRROR_FUNCS.md on GitHub #77

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Nov 18, 2024

This PR fixes displaying of the MIRROR_FUNCS.md on GitHub. Also, adds the comment that MIRROR_FUNCS.md is @generated and should not be edited manually.

Before:

image

After:

image

@alexandear alexandear marked this pull request as draft November 18, 2024 09:27
@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 11889567228

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 39.43%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/internal/mirror-table/main.go 0 6 0.0%
Totals Coverage Status
Change from base Build 10106851310: -0.2%
Covered Lines: 263
Relevant Lines: 667

💛 - Coveralls

@alexandear alexandear marked this pull request as ready for review November 18, 2024 09:30
@butuzov
Copy link
Owner

butuzov commented Nov 18, 2024

I wish i could remember reason why did I wend with table, and not markdown. Let it hang for a few days i will try update this PR asap.

@butuzov butuzov merged commit 5908922 into butuzov:main Nov 26, 2024
5 checks passed
@alexandear alexandear deleted the fix/mirror-table branch November 26, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants