Implement some improvements to random_ai and replay_loop #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add replay_loop --test-output, which nondestructively replay-tests whatever happens to be in the output directory right now * Add random_ai support for initializing a new game's data object in a more readable way, by leaning on existing diff methods * replay_loop should error out immediately if prep_replay_games fails
|
@blackshadowshade could you take a quick look at this this weekend? If it needs more scrutiny, i'm happy to wait, but i suspect you're going to rubber stamp it since it's replay-test-only, and it'd be handy for me to have the new flag in the codebase for testing other things. |
|
Right, accepting these changes to random_ai and replay testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #2953; in particular it adds the flag to nondestructively test whatever is in output/ right now, and reduces the work needed to turn test output into a responderTest to much closer to zero.
I've tested the new flags manually, and played about 900 novel and replayed games, and i'm satisfied with the changes.