New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject configuration array in constructor #3

Open

AntoineAugusti wants to merge 2 commits into buonzz:master from AntoineAugusti:master

Contributor

AntoineAugusti commented Oct 5, 2014

Clean syntax to use Laravel standards (tab indentation and things like that)
Inject configuration variables in the IoC container
Add another timeout to cURL: CURLOPT_TIMEOUT that specifies the maximum number of seconds to allow cURL functions to execute. Therefore, if the server is down, we will throw an exception quickly

AntoineAugusti added 2 commits

October 5, 2014 11:30


          Clean syntax and inject configuration array

a515f19


          Add comments

06da670

Contributor Author

AntoineAugusti commented Oct 5, 2014

Note: Travis will surely fails because at that time the freegeoip website is down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet