Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with main #55

Merged
merged 33 commits into from
Jul 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
b0377c1
Added support of parsing DateTime with a custom layout (#721)
ziflex Jan 3, 2022
64f086a
Tweaked parser for formatter (#723)
ziflex Jan 12, 2022
8d8afed
Fixed element not found error (#724)
ziflex Jan 17, 2022
0c6d4e6
Bugfix/http driver xpath (#725)
ziflex Jan 28, 2022
70a8ef7
fix go routines leakage (#726)
bundleman Feb 10, 2022
ca11d16
Updated changelog
ziflex Feb 11, 2022
0cfa6e8
Add xpath example (#740)
slowmanchan Jun 3, 2022
06344a2
Bump github.com/antchfx/xpath from 1.2.0 to 1.2.1 (#739)
dependabot[bot] Jun 3, 2022
7aaf38c
Bump github.com/antchfx/htmlquery from 1.2.4 to 1.2.5 (#738)
dependabot[bot] Jun 3, 2022
c4ab4a5
Bump github.com/jarcoal/httpmock from 1.1.0 to 1.2.0 (#736)
dependabot[bot] Jun 3, 2022
db65fe9
Add more unit tests for operators (#741)
slowmanchan Jun 3, 2022
80f21af
Add more unit tests for operators (#742)
slowmanchan Jun 4, 2022
aea7195
Updated jettison
ziflex Jun 6, 2022
be360b4
Added auto-marshalling to http functions
ziflex Jul 30, 2022
fad2035
Bump github.com/mafredri/cdp from 0.32.0 to 0.33.0 (#744)
dependabot[bot] Oct 9, 2022
44c34a0
Bump github.com/rs/zerolog from 1.26.1 to 1.28.0 (#752)
dependabot[bot] Oct 9, 2022
a9ec12b
Bump github.com/stretchr/testify from 1.7.0 to 1.8.0 (#750)
dependabot[bot] Oct 9, 2022
dd33141
Updated deps
ziflex Nov 14, 2022
d201b50
Updated dependencies (#769)
ziflex Feb 7, 2023
9b7a9a2
Dropped lagacy ANTL sdk
ziflex Feb 7, 2023
2884e02
Changed Lab installation
ziflex Mar 2, 2023
fb6b29b
Update build.yml
ziflex Mar 6, 2023
82f0e5f
Add more unit tests for operators - ToNumberOrString, ToNumberOnly (#…
tsukasaI Mar 27, 2023
99e256e
Add to_binary function (#775)
ejunebug Mar 27, 2023
cd87c46
Updated build script
ziflex Mar 28, 2023
9272b4a
Updated build script
ziflex Mar 28, 2023
4395200
Updated lab installer
ziflex Mar 28, 2023
8d745b3
Updated lab installer
ziflex Mar 28, 2023
6b2747a
Updated lab runner
ziflex Mar 28, 2023
7f6c45f
Updated dependencies (#783)
ziflex Mar 28, 2023
abd6a89
chore: use fmt.Printf instead of fmt.Println(fmt.Sprintf(...)) (#789)
testwill Oct 5, 2023
620c808
Merge branch 'master' into pr53
bundleman Jul 17, 2024
46e5ab9
Merge pull request #54 from bundleman/pr53
bundleman Jul 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix go routines leakage (MontFerret#726)
* fix go routines leakage

* Update manager.go

fmt

Co-authored-by: Tim Voronov <ziflex@users.noreply.github.com>
bundleman and ziflex authored Feb 10, 2022
commit 70a8ef790bfe08c72338e9427389d064019e4d4a
7 changes: 3 additions & 4 deletions pkg/drivers/cdp/network/manager.go
Original file line number Diff line number Diff line change
@@ -494,17 +494,16 @@ func (m *Manager) NavigateBack(ctx context.Context, skip values.Int) (values.Boo
}

func (m *Manager) WaitForNavigation(ctx context.Context, opts WaitEventOptions) error {
ctx, cancel := context.WithCancel(ctx)
defer cancel()

stream, err := m.OnNavigation(ctx)

if err != nil {
return err
}

defer stream.Close(ctx)

ctx, cancel := context.WithCancel(ctx)
defer cancel()

for evt := range stream.Read(ctx) {
if err := ctx.Err(); err != nil {
return err