Feedback implementation #8

bumsyalao · 2017-11-17T01:37:33Z

What does this PR do?

Implement feed back given

- Added HsDocs to code - Implemented confirm password

- write more test cases - remove console.logs - return errors correctly - added JsDocs - implement airbnb style guide - Fix eslint errors [Fixes #1]

- write client test for components - write client test for reducers

- write test for all actions - fix bug with jest and images - fix more eslint errors - added favicon to app - changed app port to 6116

- rebundle webpack

- git ignore dist - Add FAQ, limitations and MIT license to readme - Create an email address for postit application - Change all parameters to camelCase - Return responses as object - Change group card layout to take two cards - Add check to not allow users view message of groups they don't belong to - Add page not found to all incorrect routes

- Add posiinstall script

- Add babel-loader to dependencies

- Upgrade node and npm version

- Install babel-oreset-env

- gitignore dist

- change build script

- update dependency

- Fix to remove warnings in console. - Fix Serverside test

- format email notification

houndci-bot · 2017-11-17T09:45:46Z

server/test/routes/users.test.js

+    .post('/api/v1/user/signup')
+    .send({ chopper
+    })
+    .end((err, res) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T09:45:46Z

server/test/routes/users.test.js

+  it('should get token for all tests', (done) => {
+    api
+    .post('/api/v1/user/signup')
+    .send({ chopper


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-17T09:45:46Z

server/test/routes/users.test.js

 describe('ROUTES', () => {
  after((done) => {
    models.Users.destroy({ where: { username: 'candy' } }).then(() => done());
  });
+
+  it('should get token for all tests', (done) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T09:45:46Z

server/test/routes/users.test.js

@@ -32,10 +33,26 @@ const nullPassword = {
  password: null
 };

+let token = ''; // eslint-disable-line


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-17T09:45:46Z

server/test/routes/users.test.js

-import app from '../../app';
-import models from '../../server/models';
+import app from '../../../app';
+import models from '../../../server/models';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T09:45:47Z

server/test/routes/groups.test.js

+        done();
+      });
+    });
+    it('should not create another group with same groupName', (done) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T09:45:47Z

server/test/routes/groups.test.js

+      .set({ jwt: validToken })
+      .send(group)
+      .expect(200)
+      .end((err, res) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T09:45:47Z

server/test/routes/groups.test.js

+  });
+
+  describe('POST: (/api/v1/group) - Create', () => {
+    it('should be an object with keys and values', (done) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T09:45:47Z

server/test/routes/groups.test.js

+    Groups.destroy({ where: { groupName: 'People' } }).then(() => done());
+  });
+
+  describe('POST: (/api/v1/group) - Create', () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T09:45:47Z

server/test/routes/groups.test.js

+  });
+  after((done) => {
+    UserGroups.destroy({ where: { groupName: 'People' } });
+    Groups.destroy({ where: { groupName: 'People' } }).then(() => done());


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

- Add search page for users - Add Add User option - Create Api route to add User to group - Add footer to app - Add heading to login and register form - Add navbar to PageNotFound - Fix heroku issue [Delivers #152948431]

houndci-bot · 2017-11-17T11:03:53Z

server/test/models/users.test.js

@@ -1,18 +1,19 @@
 /* eslint-disable no-unused-expressions */
 import chai from 'chai';
-import models from '../../server/models';
+import models from '../../models';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:54Z

server/controllers/users.js

+          metaData: paginate(count, limit, offset)
+        });
+      })
+      .catch(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:54Z

server/controllers/users.js

+      .then(({ rows: users, count }) => {
+        res.status(200).send({
+          message: 'Users found',
+          users,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-17T11:03:54Z

server/controllers/users.js

-        users,
-        metaData: paginate(count, limit, offset)
+    })
+      .then(({ rows: users, count }) => {


'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:54Z

server/controllers/users.js

+      .then((userGroups) => {
+        res.status(200).send({ userGroups });
+      })
+      .catch(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:54Z

server/controllers/users.js

+      attributes: ['groupName']
+    })
+      .then((userGroups) => {
+        res.status(200).send({ userGroups });


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-17T11:03:54Z

server/controllers/users.js

-    });
+      attributes: ['groupName']
+    })
+      .then((userGroups) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:54Z

server/controllers/users.js

    Users.findOne({ where: { id: userId } })
      .then((user) => {
        if (user.length === 0) {
          res.status(404).send({ message: 'No User Found' });
        } else {
          res.status(200).send({ userInfo: user.filterUserDetails() });
        }
-      }).catch(() => {
+      })
+      .catch(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:55Z

server/test/models/users.test.js

@@ -1,18 +1,19 @@
 /* eslint-disable no-unused-expressions */
 import chai from 'chai';
-import models from '../../server/models';
+import models from '../../models';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:55Z

server/controllers/users.js

+          metaData: paginate(count, limit, offset)
+        });
+      })
+      .catch(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:55Z

server/controllers/users.js

+      .then(({ rows: users, count }) => {
+        res.status(200).send({
+          message: 'Users found',
+          users,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-17T11:03:55Z

server/controllers/users.js

-        users,
-        metaData: paginate(count, limit, offset)
+    })
+      .then(({ rows: users, count }) => {


'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:55Z

server/controllers/users.js

+      .then((userGroups) => {
+        res.status(200).send({ userGroups });
+      })
+      .catch(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:55Z

server/controllers/users.js

+      attributes: ['groupName']
+    })
+      .then((userGroups) => {
+        res.status(200).send({ userGroups });


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-17T11:03:55Z

server/controllers/users.js

-    });
+      attributes: ['groupName']
+    })
+      .then((userGroups) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-17T11:03:55Z

server/controllers/users.js

    Users.findOne({ where: { id: userId } })
      .then((user) => {
        if (user.length === 0) {
          res.status(404).send({ message: 'No User Found' });
        } else {
          res.status(200).send({ userInfo: user.filterUserDetails() });
        }
-      }).catch(() => {
+      })
+      .catch(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:12Z

server/routes/index.js

-  app.get('/api', (req, res) => res.status(200).send({
-    message: 'Welcome to the PostIt API!',
-  }));
+  app.get('/api', (req, res) =>


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:12Z

server/test/routes/users.test.js

+  phoneNumber: '09087667344',
+  password: 'medicine'
+};
+const signupUser = {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-20T15:54:12Z

server/models/usergroups.js

+  },
+    {
+      classMethods: {
+        associate: (models) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:12Z

server/middleware/sendMail.js

+  });
+};
+
+export default sendMail;


'export' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:13Z

server/middleware/sendMail.js

+    if (error) {
+      return error;
+    }
+    console.log(`${info.messageId} send: ${info.response}`);


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:13Z

server/middleware/sendMail.js

+  const mailOptions = {
+    from: '"POST_IT" <[email protected]>',
+    to: email,
+    subject: `You have a ${priorityHeader} message`,


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:13Z

server/middleware/sendMail.js

+  });
+
+  // setup email data with unicode symbols
+  const mailOptions = {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-20T15:54:13Z

server/middleware/sendMail.js

+  });
+
+  // create reusable transporter object using the default SMTP transport
+  const transporter = nodemailer.createTransport({


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-20T15:54:13Z

server/middleware/sendMail.js

+  let email = '';
+
+  users.forEach((user) => {
+    email += `${user.User.email},`;


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:13Z

server/middleware/sendMail.js

+  // get email of the users
+  let email = '';
+
+  users.forEach((user) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:14Z

server/routes/index.js

-  app.get('/api', (req, res) => res.status(200).send({
-    message: 'Welcome to the PostIt API!',
-  }));
+  app.get('/api', (req, res) =>


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:14Z

server/test/routes/users.test.js

+  phoneNumber: '09087667344',
+  password: 'medicine'
+};
+const signupUser = {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-20T15:54:14Z

server/models/usergroups.js

+  },
+    {
+      classMethods: {
+        associate: (models) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:14Z

server/middleware/sendMail.js

+  });
+};
+
+export default sendMail;


'export' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:14Z

server/middleware/sendMail.js

+    if (error) {
+      return error;
+    }
+    console.log(`${info.messageId} send: ${info.response}`);


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:14Z

server/middleware/sendMail.js

+  const mailOptions = {
+    from: '"POST_IT" <[email protected]>',
+    to: email,
+    subject: `You have a ${priorityHeader} message`,


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:14Z

server/middleware/sendMail.js

+  });
+
+  // setup email data with unicode symbols
+  const mailOptions = {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-20T15:54:15Z

server/middleware/sendMail.js

+  });
+
+  // create reusable transporter object using the default SMTP transport
+  const transporter = nodemailer.createTransport({


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-20T15:54:15Z

server/middleware/sendMail.js

+  let email = '';
+
+  users.forEach((user) => {
+    email += `${user.User.email},`;


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-20T15:54:15Z

server/middleware/sendMail.js

+  // get email of the users
+  let email = '';
+
+  users.forEach((user) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

coveralls · 2017-11-24T11:41:17Z

Changes Unknown when pulling c176eb1 on feedback-implementation into ** on master**.

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

+
+.icon-pointer {
+  cursor: pointer;
+}


Files should end with a trailing newline

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

@@ -175,10 +189,58 @@ nav ul a {
  margin-top: 10%;
 }
 .collection {
-  margin-bottom: 100px !important; 
+  margin-bottom: 100px !important;


!important should not be used

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

-        margin-right: 30px;
-      }
+  margin-top: 50px;
+  a {


Rule declaration should be preceded by an empty line

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

@@ -125,7 +139,7 @@ nav ul a {
    }

    &:hover {
-      background: rgba(229, 115, 115, 0.08);      
+      background: rgba(229, 115, 115, 0.08);


Color literals like rgba(229, 115, 115, 0.08) should only be used in variable declarations; they should be referred to via variable everywhere else.

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

+  background: #fff;
+  width: calc(100% - 300px);
+  margin-top: 0;
+  border-top: 1px solid #aaa;


Color literals like #aaa should only be used in variable declarations; they should be referred to via variable everywhere else.

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

+  right: 0;
+  bottom: 0;
+  margin: 0 auto 30px auto;
+  background: #fff;


Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

+  position: fixed;
+  right: 0;
+  bottom: 0;
+  margin: 0 auto 30px auto;


Shorthands of length 4 are not allowed. Value was 0 auto 30px auto
Shorthand form for property margin should be written more concisely as 0 auto 30px instead of 0 auto 30px auto

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

-    border-top: 1px solid #aaa;
-    height: 200px;
+.message-holder {
+  position: fixed;


Properties should be ordered background, border-top, bottom, height, margin, margin-top, position, right, width

houndci-bot · 2017-11-27T13:18:52Z

client/scss/pages/view_group.scss

+  margin: 0 auto;
+  max-height: calc(100% - 340px);
+  overflow: scroll;
+  border: none;


border: 0 is preferred over border: none

- Users should only see group they belong to

coveralls · 2017-11-27T13:24:04Z

Changes Unknown when pulling 035c651 on feedback-implementation into ** on master**.

coveralls · 2017-11-27T13:26:55Z

Changes Unknown when pulling 035c651 on feedback-implementation into ** on master**.

- include group users page - remove redundant files - remmove wrong import name

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

+    .then(group => res.status(200).send({
+      group
+    }))
+    .catch(error => res.status(404).send(error));


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

-    .then(group => res.status(200).send(group))
-    .catch(error => res.status(400).send(error));
+    .then(group => res.status(200).send({
+      group


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

   */
  retrieveGroup(req, res) {
    Groups.findById(req.params.groupid)
-    .then(group => res.status(200).send(group))
-    .catch(error => res.status(400).send(error));
+    .then(group => res.status(200).send({


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

+    .then(allGroups => res.status(200).send({
+      allGroups
+    }))
+    .catch(error => res.status(404).send(error));


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

-    .then(allGroups => res.status(200).send(allGroups))
-    .catch(error => res.status(400).send(error));
+    .then(allGroups => res.status(200).send({
+      allGroups


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

    })
-    .then(allGroups => res.status(200).send(allGroups))
-    .catch(error => res.status(400).send(error));
+    .then(allGroups => res.status(200).send({


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

      .catch((error) => {
-        res.status(400).send(`user groups error: ${error.message}`);
+        res.status(400).send(`${error.message}`);


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

      })
-      .then(savedGroup => res.status(200).send(savedGroup))
+      .then(savedGroup => res.status(200).send({
+        savedGroup,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-11-28T21:56:23Z

server/controllers/groups.js

      })
-      .then(savedGroup => res.status(200).send(savedGroup))
+      .then(savedGroup => res.status(200).send({


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

coveralls · 2017-11-28T22:00:09Z

Changes Unknown when pulling 257686c on feedback-implementation into ** on master**.

- change models and routes - change test

…/PostIt-Bootcamp-Project into rename-usergroup-model

…e-usergroup-model

houndci-bot · 2017-11-29T00:26:45Z

client/scss/pages/view_group.scss

+}
+.link-underline {
+  text-decoration: underline;
+}


Files should end with a trailing newline

houndci-bot · 2017-11-29T00:26:46Z

client/scss/pages/view_group.scss

+}
+.btn-space {
+  margin-right: 1rem;
+}


Rule declaration should be followed by an empty line

houndci-bot · 2017-11-29T00:26:46Z

client/scss/pages/view_group.scss

+
+.urgent {
+  background: red;
+}


Rule declaration should be followed by an empty line

houndci-bot · 2017-11-29T00:26:46Z

client/scss/pages/view_group.scss

+}
+
+.urgent {
+  background: red;


Color red should be written in hexadecimal form as #ff0000
Color literals like red should only be used in variable declarations; they should be referred to via variable everywhere else.

houndci-bot · 2017-11-29T00:26:46Z

client/scss/pages/view_group.scss

+
+.priority-badge {
+  background: red;
+  color: white;


Properties should be ordered background, border-radius, color, padding
Color white should be written in hexadecimal form as #ffffff
Color literals like white should only be used in variable declarations; they should be referred to via variable everywhere else.

Rename usergroup model

houndci-bot · 2017-11-29T00:32:04Z

server/test/models/users.test.js

-    it('should be valid if compared', () => {
-      expect(person.verifyPassword(userInfo.password)).to.be.true;
+    it('should be valid if compared', (done) => {
+      expect(person.verifyPassword(userDetails.password)).to.be.true;


Expected an assignment or function call and instead saw an expression.

coveralls · 2017-11-29T00:36:03Z

Changes Unknown when pulling b6c88ec on feedback-implementation into ** on master**.

houndci-bot · 2018-01-22T16:22:47Z

server/controllers/users.js

-          user.update({
+    Users.findOne({
+      where: { email }
+    }).then((user) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2018-01-22T16:22:47Z

server/controllers/users.js

-        } else {
-          user.update({
+    Users.findOne({
+      where: { email }


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:47Z

server/controllers/users.js

+      attributes: ['groupId', 'groupName']
+    })
+      .then((userGroups) => {
+        res.status(200).send({ userGroups });


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:47Z

server/controllers/users.js

-    });
+      attributes: ['groupId', 'groupName']
+    })
+      .then((userGroups) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2018-01-22T16:22:47Z

server/controllers/users.js

   */
  viewUser(req, res) {
-    const userId = req.body.userId;
+    const userId = req.decoded.userId;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:48Z

server/controllers/users.js

+              phoneNumber: foundUser.phoneNumber
+            };
+            return res.status(200).send({
+              token,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:48Z

server/controllers/users.js

+              secret,
+              { expiresIn: '1 day' }
+            );
+            const userDetails = {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:48Z

server/controllers/users.js

   */
  signin(req, res) {
    if (req.body.username && req.body.password) {
      Users.findOne({ where: { username: req.body.username } })
        .then((foundUser) => {
          if (foundUser && foundUser.verifyPassword(req.body.password)) {
-            const token = jwt.sign({
+            const token = jwt.sign(


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:48Z

server/controllers/users.js

-          return res.status(200).send({ token, userInfo });
+          return res.status(200).send({
+            token,
+            userInfo,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:48Z

server/controllers/users.js

            email: newUser.email
          };
-          return res.status(200).send({ token, userInfo });
+          return res.status(200).send({
+            token,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:49Z

server/controllers/users.js

-          user.update({
+    Users.findOne({
+      where: { email }
+    }).then((user) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2018-01-22T16:22:49Z

server/controllers/users.js

-        } else {
-          user.update({
+    Users.findOne({
+      where: { email }


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:49Z

server/controllers/users.js

+      attributes: ['groupId', 'groupName']
+    })
+      .then((userGroups) => {
+        res.status(200).send({ userGroups });


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:49Z

server/controllers/users.js

-    });
+      attributes: ['groupId', 'groupName']
+    })
+      .then((userGroups) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2018-01-22T16:22:49Z

server/controllers/users.js

   */
  viewUser(req, res) {
-    const userId = req.body.userId;
+    const userId = req.decoded.userId;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:49Z

server/controllers/users.js

+              phoneNumber: foundUser.phoneNumber
+            };
+            return res.status(200).send({
+              token,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:50Z

server/controllers/users.js

+              secret,
+              { expiresIn: '1 day' }
+            );
+            const userDetails = {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:50Z

server/controllers/users.js

   */
  signin(req, res) {
    if (req.body.username && req.body.password) {
      Users.findOne({ where: { username: req.body.username } })
        .then((foundUser) => {
          if (foundUser && foundUser.verifyPassword(req.body.password)) {
-            const token = jwt.sign({
+            const token = jwt.sign(


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:50Z

server/controllers/users.js

-          return res.status(200).send({ token, userInfo });
+          return res.status(200).send({
+            token,
+            userInfo,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2018-01-22T16:22:50Z

server/controllers/users.js

            email: newUser.email
          };
-          return res.status(200).send({ token, userInfo });
+          return res.status(200).send({
+            token,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

bumsyalao added 17 commits October 16, 2017 15:11

-Feedback impementation

d3fc6d4

Run build for Heroku

e3e587c

chore(JsDocs):

08c81a8

- Added HsDocs to code - Implemented confirm password

chore(implement-feedback)

292e0f4

- write more test cases - remove console.logs - return errors correctly - added JsDocs - implement airbnb style guide - Fix eslint errors [Fixes #1]

chore: write client test

1c51e0b

- write client test for components - write client test for reducers

chore: Write client test

3ec6cd1

- write test for all actions - fix bug with jest and images - fix more eslint errors - added favicon to app - changed app port to 6116

chore: Fix heroku issue

fa9c4b8

- rebundle webpack

chore: Fix error with Heroku

db9b490

- Add posiinstall script

chore: Fix Heroku Error

587dd1e

- Add babel-loader to dependencies

Chore: Fix Heroku Error

8f218d3

- Upgrade node and npm version

chore: Fix Heroku Error

5c68f25

- Install babel-oreset-env

Chore: Remove dist folder

6388e1d

- gitignore dist

chore: Fix Heroku Error

d0832d2

- change build script

chore: Fix Heroku Error

e8b1885

- update dependency

Chore: Implement feedback

f39b297

- Fix to remove warnings in console. - Fix Serverside test

Feature: Implement email notification

4aed19b

- format email notification

bumsyalao temporarily deployed to postit-now November 17, 2017 01:50 Inactive

bumsyalao force-pushed the feedback-implementation branch 3 times, most recently from 8c87991 to 34ac981 Compare November 17, 2017 09:45

houndci-bot reviewed Nov 17, 2017

View reviewed changes

bumsyalao force-pushed the feedback-implementation branch from 34ac981 to 89bc76e Compare November 17, 2017 10:59

bumsyalao temporarily deployed to postit-now November 17, 2017 10:59 Inactive

feature: Implement Add user

5fb5077

- Add search page for users - Add Add User option - Create Api route to add User to group - Add footer to app - Add heading to login and register form - Add navbar to PageNotFound - Fix heroku issue [Delivers #152948431]

bumsyalao force-pushed the feedback-implementation branch from 89bc76e to 5fb5077 Compare November 17, 2017 11:02

houndci-bot reviewed Nov 17, 2017

View reviewed changes

houndci-bot reviewed Nov 20, 2017

View reviewed changes

bumsyalao force-pushed the feedback-implementation branch from 2e71ff9 to c176eb1 Compare November 24, 2017 11:37

bumsyalao force-pushed the feedback-implementation branch from c176eb1 to a4e5762 Compare November 27, 2017 13:18

houndci-bot reviewed Nov 27, 2017

View reviewed changes

bumsyalao force-pushed the feedback-implementation branch from a4e5762 to 904f0aa Compare November 27, 2017 13:19

bumsyalao temporarily deployed to postit-now November 27, 2017 13:20 Inactive

chore: User's group

035c651

- Users should only see group they belong to

bumsyalao force-pushed the feedback-implementation branch from 904f0aa to 035c651 Compare November 27, 2017 13:21

chore: implement feedback

257686c

- include group users page - remove redundant files - remmove wrong import name

houndci-bot reviewed Nov 28, 2017

View reviewed changes

bumsyalao added 8 commits November 29, 2017 00:31

chore: rename usergroups model

a3933b7

- change models and routes - change test

Transferring API Description file from Apiary.io

003bc3c

Merge branch 'rename-usergroup-model' of https://github.com/bumsyalao…

e64fbc2

…/PostIt-Bootcamp-Project into rename-usergroup-model

Merge https://github.com/bumsyalao/PostIt-Bootcamp-Project into renam…

a6b2e17

…e-usergroup-model

Rename usergroups.test.js to userGroups.test.js

3edf9b3

Rename usergroups.test.js to userGroups.test.js

6defc13

Rename usergroups.js to userGroups.js

bf9ad8c

Rename usergroups.js to userGroups.js

faeb491

houndci-bot reviewed Nov 29, 2017

View reviewed changes

bumsyalao deployed to postit-now November 29, 2017 00:27 View deployment

Merge pull request #9 from bumsyalao/rename-usergroup-model

b6c88ec

Rename usergroup model

bumsyalao force-pushed the feedback-implementation branch from f7935b2 to b6c88ec Compare November 29, 2017 00:31

houndci-bot reviewed Nov 29, 2017

View reviewed changes

made changes

0e51bb8

houndci-bot reviewed Jan 22, 2018

View reviewed changes

Feedback implementation #8

Are you sure you want to change the base?

Feedback implementation #8

Conversation

bumsyalao commented Nov 17, 2017

What does this PR do?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 27, 2017

coveralls commented Nov 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment