Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Explorer section to the Help Center #305

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Add API Explorer section to the Help Center #305

merged 9 commits into from
Nov 29, 2024

Conversation

jayk-u
Copy link
Contributor

@jayk-u jayk-u commented Nov 21, 2024

Here's the first draft of the PR for the API Explorer section in the Help Center.

  • There are no screenshots at the moment, they won’t be added to the PR until the middle of next week.
  • I had an issue with the preview on my end (looks like a bridgetown issue), so if someone could check if it works on their side, that would be great. (I’ll see what the preview looks like here anyway.)

@jayk-u jayk-u self-assigned this Nov 21, 2024
@jayk-u jayk-u marked this pull request as draft November 21, 2024 15:36
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit 736ad02
🔍 Latest deploy log https://app.netlify.com/sites/bump-content-hub/deploys/674998c47c5e2a0008f806c9
😎 Deploy Preview https://deploy-preview-305--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jayk-u
Copy link
Contributor Author

jayk-u commented Nov 21, 2024

I did modify the sidebar.yaml, though. Maybe I made a mistake, I’ll check it again.

@jayk-u
Copy link
Contributor Author

jayk-u commented Nov 21, 2024

Fixed the sidebar issue, yay \o/

Copy link
Contributor

@ChristopheDujarric ChristopheDujarric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content so far!

Just one small suggestion.

Also, don't forget to add all redirects for external traffic to find the new path of existing pages, and to update all of our own content pointing to those pages with the new URLs.

Copy link
Contributor

@grossyoan grossyoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this work Jay!

Lgtm, apart from the small comment around sharing and version mismatch.

@jayk-u jayk-u marked this pull request as ready for review November 29, 2024 00:58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the contents of this one, as it's not mentioning the API Explorer yet, but it does mention the other pages in this section?

@grossyoan
Copy link
Contributor

Lgtm, thanks Jay!

@jayk-u jayk-u merged commit 274670c into main Nov 29, 2024
5 checks passed
@ChristopheDujarric ChristopheDujarric deleted the api-explorer-help branch November 29, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants