Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/image optimization #168

Merged

Conversation

philsturgeon
Copy link
Contributor

  • Added code-first guide
  • optimized images for quicker load on web

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit 34862ca
🔍 Latest deploy log https://app.netlify.com/sites/bump-content-hub/deploys/65ad6a00ae62af00097d8e96
😎 Deploy Preview https://deploy-preview-168--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@scharrier scharrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we only keep the images optimization here, and keep the 2 guides in their own PR? (if it generates conflict let's forget my comment and merge everything from the other PR ;))

@philsturgeon philsturgeon force-pushed the docs/image-optimization branch from 8118ce0 to 34862ca Compare January 21, 2024 19:01
@philsturgeon
Copy link
Contributor Author

philsturgeon commented Jan 21, 2024

It woudn't have made a conflict going to main as it was just based off the other branch assuming it would be merged soon, but I've split them entirely now. Good to go!

@ChristopheDujarric ChristopheDujarric merged commit 4a05580 into bump-sh:main Jan 22, 2024
5 checks passed
paulRbr pushed a commit to paulRbr/docs-3 that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants