Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set HTTP_PATH if it already has origin remote #1905

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sh1nj1
Copy link

@sh1nj1 sh1nj1 commented Feb 3, 2025

This PR fixes uninitialized HTTP_PATH when it already has origin github remote url.

Error message:

Would you like to add a 'Deploy to Heroku' button to your project. [Y/n]

Adding a 'Deploy to Heroku' button.
/Users/me/project/me/bullet_train/bin/configure-scripts/deploy_button_heroku.rb:13:in '<top (required)>': uninitialized constant HTTP_PATH (NameError)

    HTTP_PATH
    ^^^^^^^^^
        from /Users/me/.local/share/mise/installs/ruby/3.4.1/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require'
        from /Users/me/.local/share/mise/installs/ruby/3.4.1/lib/ruby/3.4.0/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
        from ./bin/configure:22:in '<main>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant