Skip to content

Commit

Permalink
Fix the confusing workflow diagram when deployment is enabled
Browse files Browse the repository at this point in the history
Fixes #1816
  • Loading branch information
jagthedrummer committed Jan 27, 2025
1 parent 356ff5e commit 2f3909d
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
11 changes: 11 additions & 0 deletions .github/workflows/ci-cd-pipeline-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@ on:
branches: [ "main" ]

jobs:
# NOTE: This is here just to make the workflow visualization layout better.
# Without it the layout is really bad and confusing.
calculate_matrix:
name: 🤷 Fake Matrix
runs-on: ubuntu-latest
steps:
- name: Do Nothing
run: echo "This is a useless step that just helps things look nicer..."
shell: bash
minitest:
name: 🧪 Minitest
uses: ./.github/workflows/_run_tests.yml
Expand All @@ -20,13 +29,15 @@ jobs:
name: 🔬 Standardrb
uses: ./.github/workflows/_standardrb.yml
secrets: inherit
needs: calculate_matrix
permissions:
checks: write
contents: read
db_schema:
name: 🔎 DB Schema
uses: ./.github/workflows/_database_schema_check.yml
secrets: inherit
needs: calculate_matrix
combine_runtime_logs:
name: 🪵 Combine Runtime Logs for Parallel Tests
uses: ./.github/workflows/_combine_runtime_logs.yml
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/ci-cd-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@ on:
types: [opened, synchronize, reopened]

jobs:
# NOTE: This is here just to make the workflow visualization layout better.
# Without it the layout is really bad and confusing.
calculate_matrix:
name: 🤷 Fake Matrix
runs-on: ubuntu-latest
steps:
- name: Do Nothing
run: echo "This is a useless step that just helps things look nicer..."
shell: bash
minitest:
name: 🧪 Minitest
uses: ./.github/workflows/_run_tests.yml
Expand All @@ -20,13 +29,15 @@ jobs:
name: 🔬 Standardrb
uses: ./.github/workflows/_standardrb.yml
secrets: inherit
needs: calculate_matrix
permissions:
checks: write
contents: read
db_schema:
name: 🔎 DB Schema
uses: ./.github/workflows/_database_schema_check.yml
secrets: inherit
needs: calculate_matrix
combine_runtime_logs:
name: 🪵 Combine Runtime Logs
uses: ./.github/workflows/_combine_runtime_logs.yml
Expand Down

0 comments on commit 2f3909d

Please sign in to comment.