Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IVS-228 purepythonparser for critical gherkin checks and info extraction #127

Merged
merged 4 commits into from
Jan 22, 2025
Merged

IVS-228 purepythonparser for critical gherkin checks and info extraction #127

merged 4 commits into from
Jan 22, 2025

Conversation

aothms
Copy link
Collaborator

@aothms aothms commented Nov 14, 2024 •
edited
Loading

Doesn't fully work yet. Seems that whitespace within strings is discarded. So MVD and authoring are wrong.

afbeelding

@aothms aothms requested a review from Ghesselink November 14, 2024 21:16
@aothms
Copy link
Collaborator Author

aothms commented Nov 15, 2024

Should be ready for review with IfcOpenShell/step-file-parser@8a5349f

I didn't sync any submodules... so checkout the submodule heads when reviewing

@aothms aothms changed the title IVS-228 purepythonparser for critical gherkin checks and info extraction [WIP] IVS-228 purepythonparser for critical gherkin checks and info extraction Nov 15, 2024
Ghesselink
Ghesselink reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@Ghesselink Ghesselink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just had to run the step_file_parser as a module to get it running. Along with some changes on the gherkin-side (also see Jira)
Just have to wait a new ifcopenshell build.

backend/apps/ifc_validation/tasks.py
Comment on lines +541 to +547
# @nb previously we also checked for:
# or (len(proc.stderr) > 0):
#
# but I now get warnings:
#
# - features/environment.py:86: ContextMaskWarning: user code is masking context attribute 'gherkin_outcomes';
# see the tutorial for what this means
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed this warning a while ago, it appears every run in between scenario's. It seems it is because we set

old_outcomes = getattr(context, 'gherkin_outcomes', []) 
context.gherkin_outcomes = old_outcomes

I think it's some leftover from the past, when had issues with context resetting/overlap between scenario's. The lines don't affect the outcomes that are being outputted to the tests or stored in the database. When I remove them, the warning goes away and nothing changes when running pytest or checking the platform.
It's probably safe and clearer to delete them ..

backend/apps/ifc_validation/tasks.py
desc = ifc_file.header.file_description[0][0]
else:
desc = ifc_file.header.file_description.description[0]
# @todo implement based on grammar in header agreement PDF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this will be covered by IVS-179 / the header policy checks ?
There's at least some overlap.

@Ghesselink
submodule -> DEV
fb2a6a6
@Ghesselink
Squashed commit of the following:
5ba6b65 
commit 7e34376
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Jan 22 14:04:57 2025 +0000

    Update of submodules (bSI-Bot via GH action)

commit db0b405
Merge: fe26a36 4c31a78
Author: Raphael <[email protected]>
Date:   Sun Jan 19 15:00:36 2025 +0000

    Merge pull request #138 from buildingSMART/tfk-ivs323-none-in-application

    IVS-323 None in IfcApplication

commit 4c31a78
Author: Thomas Krijnen <[email protected]>
Date:   Thu Jan 16 20:49:21 2025 +0100

    Fix parse_info_subtask none in IfcApplication

commit fe26a36
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Thu Jan 16 13:40:40 2025 +0000

    Update of submodules (bSI-Bot via GH action)

commit 6ab52e2
Merge: b482e7c 259c5ba
Author: Scott Lecher <[email protected]>
Date:   Wed Jan 15 11:04:10 2025 -0500

    Merge pull request #133 from buildingSMART/fix/IVS-282-ALS017

    upgrade ifcopenshell version for polynomial coefficients fix

commit b482e7c
Author: rw-bsi <[email protected]>
Date:   Wed Jan 15 08:56:55 2025 +0000

    fix for instance linking

commit e9f3565
Merge: d9a0e48 edfb387
Author: Raphael <[email protected]>
Date:   Sat Jan 11 12:32:57 2025 +0000

    Merge pull request #135 from buildingSMART/IVS-311---Update-Django-Admin-for-ValidationRequest

    IVS-311 - Update Django Admin for ValidationRequest model

commit edfb387
Author: Raphael <[email protected]>
Date:   Fri Jan 10 21:16:36 2025 +0000

    Update Django Admin for ValidationRequest model

    - added Authoring Tool
    - added Is Vendor ?
    - updated searching/filtering/ordering

commit d9a0e48
Author: Geert Hesselink <[email protected]>
Date:   Fri Jan 3 19:50:14 2025 +0100

    Install npmath

commit 47b1fca
Author: Geert Hesselink <[email protected]>
Date:   Mon Dec 23 04:05:29 2024 +0100

    Install networkx

commit af65389
Author: rw-bsi <[email protected]>
Date:   Sun Dec 15 15:53:44 2024 +0000

    add makefile target for apple silicon

commit 259c5ba
Author: civilx64 <[email protected]>
Date:   Mon Dec 9 07:54:56 2024 -0500

    upgrade ifcopenshell version for polynomial coefficients fix

    This is necessary for the correct processing of alignment data
    in models with non-SI units where IfcCurveSegment.ParentCurve
    is of type IfcPolynomialCurve

    (IVS-282)

commit 1a46f8f
Merge: e3e8723 5c06f07
Author: Raphael <[email protected]>
Date:   Sun Dec 8 14:58:43 2024 +0000

    Merge pull request #132 from buildingSMART/IVS-268_Fix_DRF_API_access

    Fix for DRF API access

commit 5c06f07
Author: rw-bsi <[email protected]>
Date:   Sat Dec 7 14:53:42 2024 +0000

    map public_id to private id

commit e3e8723
Author: rw-bsi <[email protected]>
Date:   Fri Dec 6 18:19:14 2024 +0000

    update CompanyAdmin

commit cab9ca9
Author: rw-bsi <[email protected]>
Date:   Fri Dec 6 16:58:12 2024 +0000

    Mark VS API as in Preview mode

commit 4793677
Author: rw-bsi <[email protected]>
Date:   Fri Dec 6 16:39:17 2024 +0000

    support fetching outcomes and tasks by public_id

commit a3785ea
Author: rw-bsi <[email protected]>
Date:   Fri Dec 6 16:19:55 2024 +0000

    support filtering Validation Tasks and Validation Outcomes by request/task id(s)

commit d606475
Author: rw-bsi <[email protected]>
Date:   Fri Dec 6 15:38:01 2024 +0000

    update API - fetch by public_id

commit 293eb7a
Author: rw-bsi <[email protected]>
Date:   Fri Dec 6 15:17:26 2024 +0000

    fix for DRF API access

commit 960cc37
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Nov 27 23:04:53 2024 +0000

    Update of submodules (bSI-Bot via GH action)

commit e3d1ff1
Merge: ca51a0d 5b6bb4d
Author: Raphael <[email protected]>
Date:   Tue Nov 26 18:40:51 2024 +0000

    Merge pull request #131 from buildingSMART/feature/IVS-235_bulk_update_modelinstances

    IVS-235 - update Instance Completion task + update admin

commit 5b6bb4d
Author: rw-bsi <[email protected]>
Date:   Sun Nov 24 18:16:21 2024 +0000

    update Instance Completion task + update admin

commit ca51a0d
Merge: e84453c 25b2866
Author: Geert Hesselink <[email protected]>
Date:   Sun Nov 24 16:55:55 2024 +0100

    Merge pull request #130 from buildingSMART/IVS-265_Remove_Stepfileparser_Gitmodule

    IVS-265 Remove stepfileparser module

commit e84453c
Author: Raphael <[email protected]>
Date:   Sun Nov 24 14:46:14 2024 +0000

    Update Dockerfile

    added postgresql-client package

commit 25b2866
Author: rw-bsi <[email protected]>
Date:   Sun Nov 24 13:57:53 2024 +0000

    remove sfp submodule

commit d6a407c
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Nov 24 13:22:11 2024 +0000

    Update of submodules (bSI-Bot via GH action)

commit 2136186
Author: Geert Hesselink <[email protected]>
Date:   Sat Nov 23 22:26:44 2024 +0100

    IVS-255 - Run SPF as module & update ifcopenshell

commit e889290
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Mon Nov 18 22:34:25 2024 +0000

    Update of submodules (bSI-Bot via GH action)

commit eae9ba0
Author: rw-bsi <[email protected]>
Date:   Mon Nov 18 22:33:34 2024 +0000

    FIX: ImproperlyConfigured exception

commit d905daf
Merge: 9433bcf 29687c0
Author: Raphael <[email protected]>
Date:   Mon Nov 18 16:42:29 2024 +0000

    Merge pull request #128 from buildingSMART/feature/IVS-239_Version_UserAdditionalInfo

    IVS-239 - Version and UserAdditionalinfo

commit 9433bcf
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Mon Nov 18 16:27:28 2024 +0000

    Update of submodules (bSI-Bot via GH action)

commit 29687c0
Author: rw-bsi <[email protected]>
Date:   Sun Nov 17 15:40:36 2024 +0000

    Ability to manage Version and UserAdditionalInfo in Django Admin
@Ghesselink Ghesselink merged commit 642c160 into development Jan 22, 2025
3 checks passed
@Ghesselink Ghesselink deleted the ivs228-purepythonparser branch January 22, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghesselink Ghesselink Ghesselink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aothms @Ghesselink