Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go and golangci-lint #23

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Update go and golangci-lint #23

merged 3 commits into from
Aug 30, 2024

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Aug 30, 2024

Now that a new version of Go has been released, this bumps the versions used in this repo.

This also updates golangci-lint to the latest, which called for some config changes to eliminate warnings.

Comment on lines +234 to +235
minSize := -math.Pow(2, float64(bitSize-1))
maxSize := math.Pow(2, float64(bitSize-1))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed predeclared linting in Go v1.23.

@smaye81 smaye81 requested review from mfridman, rodaine and Alfus August 30, 2024 16:09
@smaye81 smaye81 merged commit 587beba into main Aug 30, 2024
5 checks passed
@smaye81 smaye81 deleted the sayers/update_go_1.22 branch August 30, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants