Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go_features.proto location in WKT #825

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update go_features.proto location in WKT #825

merged 1 commit into from
Jan 9, 2025

Conversation

unmultimedio
Copy link
Member

@unmultimedio unmultimedio commented Jan 9, 2025 •
edited
Loading

WKT syncing did not find go_features.proto file:

processing reference protocolbuffers/wellknowntypes:v29.3
cp: cannot stat '../go/go_features.proto': No such file or directory

They moved it in this commit:

‎go/go_features.proto -> ‎go/google/protobuf/go_features.proto

Fixes #824

@unmultimedio unmultimedio requested review from pkwarren and jhump January 9, 2025 14:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 9, 2025, 2:17 PM

@unmultimedio unmultimedio merged commit ebbf189 into main Jan 9, 2025
6 checks passed
@unmultimedio unmultimedio deleted the jfigueroa/fix-wkt-gofeatures branch January 9, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkwarren pkwarren pkwarren approved these changes

@jhump jhump Awaiting requested review from jhump

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected Fetch references failure
2 participants
@unmultimedio @pkwarren