-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sync one more
gofeatures
reference (#822)
Backend BSR currently does not respect `buf.yaml` dependency pins and instead it uses the latest synced dependency reference, as [stated in the README](https://github.com/bufbuild/modules?tab=readme-ov-file#how-we-handle-dependencies), which means: - All `gofeatures` synced references always depended at the latest `wellknowntypes` available at the moment, not specifically `v27.0` (as its synced `buf.yaml` suggested). Right now it depends on `v29.1`. - Latest `gofeatures` reference `v1.36.1` is currently stuck and unsyncable in BSRs because it does not build, due to a duplicate proto path: `go_features.proto` file, [recently added to `wellknowntypes` module in `v29.2`](https://buf.build/protocolbuffers/wellknowntypes/compare/v29.1..v29.2). Fix plan is: - [x] Make sure this is the only `buf.yaml` that pins to a specific dependency. - [x] Mark `[email protected]` reference as _skippable_, so it skips to `v1.36.2` from this PR. - [x] Set the BSR to respect the pinned deps (as long as they're synced references/labels). We don't want to do this step before, because the `gofeatures` dependency to `wellknowntypes` would jump backwards from `v29.1` (what currently depends on), to `v27.0` (what's synced in the central bucket). Then we can merge this PR and release `modules`, so BSR picks up this new reference and syncs it.
- Loading branch information
1 parent
74e6984
commit 3f5cbd2
Showing
6 changed files
with
19 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
version: v1 | ||
name: buf.build/protocolbuffers/gofeatures | ||
deps: | ||
- buf.build/protocolbuffers/wellknowntypes:v27.0 | ||
- buf.build/protocolbuffers/wellknowntypes:v29.1 |
4 changes: 4 additions & 0 deletions
4
...632dfb05fc719120d45582c6677ea90cd8fb68c20241ff041b34993a5bbcc1bca4302ed323036da9277d19699
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
4 changes: 4 additions & 0 deletions
4
...61592f98aa175b1a4f0670e5be25c1f9a4a098e060054792b37c28d3112785d07b867746f5eaad45a25f72128
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters