Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI trigger test runs on pull requests events #3591

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Jan 14, 2025

This changes CI tests to trigger on pull requests events, or when pushed to main. This has the following benefits:

  • tests are run on the merged state of the target branch so can capture conflicting changes earlier
  • forks from third party contributors will now have tests run as part of the PR workflow
  • on merge, changes will still be tested on main

This changes CI tests to trigger on pull requests events, or when pushed
to main. This has the following benefits:
- tests are run on the merged state of the target branch so can capture
  conflicting changes earlier
- forks from third party contributors will now have tests run as part of
  the PR workflow
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 14, 2025, 2:21 AM

@emcfarlane emcfarlane marked this pull request as ready for review January 14, 2025 02:29
@emcfarlane emcfarlane merged commit cc52cd6 into main Jan 30, 2025
13 checks passed
@emcfarlane emcfarlane deleted the ed/ciOnPREvents branch January 30, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants