Skip to content

Commit

Permalink
add broken test using v1 config
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewparmet committed Sep 20, 2024
1 parent 88b659f commit 115c9df
Show file tree
Hide file tree
Showing 4 changed files with 73 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/test/kotlin/build/buf/gradle/LintWithProtobufGradleTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@

package build.buf.gradle

import com.google.common.truth.Truth.assertThat
import org.gradle.language.base.plugins.LifecycleBasePlugin.CHECK_TASK_NAME
import org.junit.jupiter.api.Test
import java.nio.file.Paths

class LintWithProtobufGradleTest : ConfigOverrideableLintTests, AbstractLintTest() {
@Test
Expand All @@ -41,4 +44,14 @@ class LintWithProtobufGradleTest : ConfigOverrideableLintTests, AbstractLintTest
fun `lint a file with an implementation dependency and a google dependency with the protobuf-gradle-plugin`() {
assertSuccess()
}

@Test
fun `lint a file with an implementation dependency and a lint config with the protobuf-gradle-plugin`() {
val result = gradleRunner().withArguments(":$CHECK_TASK_NAME").buildAndFail()
assertThat(result.output).contains("Enum zero value name \"BROKEN_ENUM_NONSPECIFIED\" should be suffixed with \"_UNSPECIFIED\"")

Paths.get(projectDir.path, "buf.yaml").toFile().replace("#", "")

assertSuccess()
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
version: v1
lint:
ignore:
- google
- protokt
use:
- DEFAULT
except:
#- ENUM_ZERO_VALUE_SUFFIX
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
plugins {
id 'java'
id 'com.google.protobuf' version "$protobufGradleVersion"
id 'build.buf'
}

repositories {
mavenCentral()
}

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protobufVersion"
}
}

compileJava.enabled = false

dependencies {
implementation "com.google.protobuf:protobuf-java:$protobufVersion"
implementation "com.toasttab.protokt:protokt-runtime:0.6.5"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Copyright 2023 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

syntax = "proto3";

package buf.test.v1;

import "google/protobuf/any.proto";
import "protokt/protokt.proto";

message BasicMessage {
google.protobuf.Any any = 1;
protokt.ProtoktFileOptions protokt_file_options = 2;

enum BrokenEnum {
BROKEN_ENUM_NONSPECIFIED = 0; // should be _UNSPECIFIED
}
}

0 comments on commit 115c9df

Please sign in to comment.