Support duplicate action comments on PRs #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The action may be run multiple times as requested. This isn't supported by the PR comment status update as it presumes a single run of a v2 style workspace. To support this case we now dedupe comments on workflow and job name, setting the job name in the PR to differentiate runs.
emcfarlane
force-pushed
the
ed/multiComments
branch
from
1c1623c to
4b4759b
Compare
This comment has been minimized.
This comment has been minimized.
|
also need to update screenshot of summary comment in main readme |
nicksnyder
approved these changes
Jul 19, 2024
|
Leaving branch as it may be referenced, to delete on release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action may be run multiple times as requested. This isn't supported by the PR comment status update as it presumes a single run of a v2 style workspace. To support this case we now dedupe comments on workflow and job name. The
viewlink is moved to a<workflow> / <job> (pull_request)link in the comment description to help users differentiate runs. The name matches the status name below the CI fold. Note: there is no step level ID provided to the action so each invocation must be unique combination of workflow and job name otherwise the comment will update a previous comment.Fixes #51