Fix undefined steps for partial workflow #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR.
|
emcfarlane
commented
May 30, 2024
src/main.ts
Outdated
| @@ -55,8 +54,8 @@ async function main() { | |||
| // NB: Write empties the buffer must be after the comment. | |||
| await summary.write(); | |||
| // Finally, set the status of the action. | |||
| for (const key of Object.keys(steps)) { | |||
| if (steps[key].status == Status.Failed) { | |||
| for (const [key, value] of Object.entries(steps)) { | |||
There was a problem hiding this comment.
The Object.entries looses the type and goes to string, any.
There was a problem hiding this comment.
Yes, unfortunately typescript is representing javascript correctly here. Steps could contain other things. You could help it be explicit with something like:
for (const [key, value] of Object.entries(steps) as [
keyof Steps,
Result | undefined
][]) {Will suffice to make TS happy.
There was a problem hiding this comment.
Thanks! Added the type sig, but still don't get an error on value.status vs value?.status. Seems like the value doesn't respect the undefined or it makes no diff to the type check here?
There was a problem hiding this comment.
Hmm, that is weird, haven't seen it such that it coerced. Might be a TS option that I'm missing somewhere.
nicksnyder
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have an error report of:
Error: Cannot read properties of undefined (reading 'status'). I believe it's from thesteps[key].status == Status.Failedif the value is in the object but undefined. Removed the class for an object that is allowed to be partial and added more?.guards for field access.