Update version docs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR.
|
|
@emcfarlane not sure why the status comment here is reporting format as failed and lint as skipped |
emcfarlane
reviewed
May 30, 2024
|
The status comment is an integration test for this CI. It's only present on PRs to the |
nicksnyder
commented
May 30, 2024
There was a problem hiding this comment.
The status comment is an integration test for this CI. It's only present on PRs to the buf-action with the fail and skip checking we report the correct values for a failed or skipped test.
It is a bit non-obvious this is an integration test that collides with regular development. Would be nice to think about if there is a different way we could accomplish this.
emcfarlane
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.