Disable --create on push by default
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push by default sets `--create` flag to automatically create the repostory if it doesn't exist. This behaviour, however, requires elevated permissions not usually present in CI. In most cases this won't be needed as the modules will already be created. Therefore to cover the common case we now change the default input for `push_create` to false. To maintain the current behaviour explicitly set `push_create: true`.
|
The latest Buf updates on your PR.
|
|
Not going to merge this. We should allow writers permission to create repos. |
|
Closing, changing scope of writers to allow creating repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push by default sets the flag
--createto automatically create the repository if it doesn't exist. This behaviour, however, requires elevated permissions not usually present in CI. In most cases this won't be needed as the modules will already be created. Therefore to cover the common case we now change the default input forpush_createto false. To maintain the current behaviour explicitly setpush_create: true.