fix: make JsonDiffer thread safe (#683)

Concurrent execution of JsonDiffer() on multiple threads causes ArgumentOutOfRangeException during Dispose(). Create new instance of JsonPatchDeltaFormatter for every call. Please refer to this issue: #682 --------- Co-authored-by: AVEVA\rajani.rao <[email protected]> Co-authored-by: Christoph Bühler <[email protected]>
buehler · Jan 17, 2024 · 5379ee3 · 5379ee3
1 parent 00d70a7
commit 5379ee3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/KubeOps.Operator.Web/Webhooks/Admission/Mutation/JsonDiffer.cs b/src/KubeOps.Operator.Web/Webhooks/Admission/Mutation/JsonDiffer.cs
@@ -9,12 +9,12 @@ namespace KubeOps.Operator.Web.Webhooks.Admission.Mutation;
 
 internal static class JsonDiffer
 {
-    private static readonly JsonPatchDeltaFormatter Formatter = new();
-
     public static string Base64Diff(this JsonNode from, object? to)
     {
+        var formatter = new JsonPatchDeltaFormatter();
+
         var toToken = GetNode(to);
-        var patch = from.Diff(toToken, Formatter)!;
+        var patch = from.Diff(toToken, formatter)!;
 
         return Convert.ToBase64String(Encoding.UTF8.GetBytes(patch.ToString()));
     }