[OMCT-369] 피드 목록 조회 테스트 추가 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HandmadeCloud
approved these changes
Nov 29, 2023
Comment on lines
86
to
93
| given(feedRepository.findAllByCursor( | ||
| eq(myPageMemberId), | ||
| anyBoolean(), | ||
| eq(hobby), | ||
| eq(sortCondition), | ||
| eq(parameters.cursorId()), | ||
| eq(pageSize) | ||
| ) |
There was a problem hiding this comment.
모든 내용을 eq를 사용해서 해결하신 이유가 있나요?
There was a problem hiding this comment.
anyBoolean()을 사용려다보니 matcher로 통일해야 해서 그렇게 했습니다.
| Long myPageMemberId = 1L; | ||
| FeedSortCondition sortCondition = FeedSortCondition.RECENT; | ||
| Member member = MemberBuilder.build(memberId); | ||
| int pageSize = parameters.size() == null ? DEFAULT_PAGE_SIZE : parameters.size(); |
There was a problem hiding this comment.
내부 로직에 있을텐데 이렇게 해주신 이유가 있나요?
There was a problem hiding this comment.
내부 로직과 별개로 내부 동작이 옳바르게 작동되는지 확인하기 위해 테스트용 데이터를 만들었습니다.
이 과정에서 내부와 로직이 같을 수 있다고 생각합니다
예로들어 pageSize는 테스트에서 CursorPageParameters 객체의 size 값이 null 일 때 DEFAULT_PAGE_SIZE로 반환되는지 확인하기 위한 데이터를 직접 만들고 있습니다. 이 코드는 내부와 동작이 유사할 수 있지만 리팩토링을 하거나 코드를 수정할 때 도움이 된다고 생각합니다.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 종류
어떤 종류의 PR인지 아래 항목 중에 체크 해주세요.
📌 어떤 기능이 추가 되었나요?
Issue Number
OMCT-369
기능 설명
피드 목록 조회 테스트 추가
📌 기존에 있던 기능에 영향을 주나요?