-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicative grid package #286
base: develop
Are you sure you want to change the base?
Conversation
# Conflicts: # dist/blocks.editor.build.css # dist/blocks.style.build.css
Visual regression between sandbox and ID demos: passed. The failure in this report is due to a long load time. |
Visual regression on COM: passed |
Visual regression on LAW: passed |
Visual regression on SPH: passed |
One Ed: passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #285 by removing a duplicative reference to the responsive foundation grid package.
The purpose of the
tools-cgb
package in Responsive Foundation is to only print the exact CSS classes your plugin needs. This includes all icons and grid classes. The proper way to change this behavior is to change the variables above it:Changing any of these values to "true" will print all classes out to the CSS, including all grid classes.
That said, that will re-enable this duplicative behavior. My strong suspicion is that we don't actually need all those classes. I don't see any references to the grid classes in the plugin except for in the Sass files, where placeholder classes are being used. I verified that this line was introduced here: ebd1a7d
This was probably to support extending the
.col-
classes. These have since been refactored to use placeholder classes, as intended, and it should now be safe to remove this import.