Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that caused bars, tracks to be played to channel 1 #96

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yansnow78
Copy link

@yansnow78 yansnow78 commented Mar 23, 2022

  • fix bug in function play_Note that was making all notes to be played on channel 1 when channel was not set in Note object, ignoring erroneously channel parameter in play_NoteContainer, play_Bar, play_Bars, play_Tracks, ....
    The following code was not working
fluidsynth.set_instrument(2, 34, 0)
fluidsynth.play_Track(t, 2)
  • fix similar bug with velocity paramater in function play_Note that was ignoring erroneously veolcity parameter

  • Fix bug that caused all tracks to play with instrument 1 when track.instrument is not set.
    The following code was not working

fluidsynth.set_instrument(1, 34, 0)
fluidsynth.set_instrument(2, 15, 0)
fluidsynth.play_Tracks((t, t), (1, 2))
  • Fix bug that caused track to play with wrong instrument, ignoring erroneously track.instrument.
  • The following code was not working
t = Track(MidiInstrument ("Rock Organ"))
fluidsynth.play_Track(t)
  • Add possibilty to pass a string or a MidiInstrument to set_instrument.
fluidsynth.set_instrument(1, "Rock Organ", 0)
fluidsynth.set_instrument(1, MidiInstrument ("Rock Organ"), 0)

Fixed bug that caused all tracks to play to channel 1
…nstrument is not set

Add possibilty to pass a string or a MidiInstrument to set_instrument
Fix bug that caused stop_Note to ignore channel parameter
Fix bug that caused int note to not be accepted anymore in play_Note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant