Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing velocity and channel attributes of Note class #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PettaBoy
Copy link
Contributor

@PettaBoy PettaBoy commented Sep 5, 2021

This has been mentioned by several people also.

@edudobay
Copy link
Collaborator

edudobay commented Sep 7, 2021

Hi @PettaBoy, what exactly is the purpose of this change? The velocity and channel attributes are still referenced by other methods. Also, they are used in several places across the codebase, so there's more to removing them than just removing these two lines.

@PettaBoy
Copy link
Contributor Author

PettaBoy commented Sep 9, 2021

I understand that @edudobay, but this is becoming a big problem in the development of one of my applications.
If I leave the code alone, then I might not be able to change the program of the keyboard unless I am at channel 1. This will severely affect the chances of me developing a multi channel application in the future. Also, the keyboard won't be able to play the MIDI percussion instruments with the current code.
My bad, though. Should have done more research before putting this out.
Here's the Github repo of the app if you want to check it out:
https://github.com/PettaBoy/VirtualMusicKeyboard

@PettaBoy
Copy link
Contributor Author

PettaBoy commented Sep 10, 2021

Thought I'll reference #21 and #22 to this as well. Unfortunately it got closed by the author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants