Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jazz scales (and minor midi fixes) #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jazz scales (and minor midi fixes) #66

wants to merge 2 commits into from

Conversation

samg7b5
Copy link
Contributor

@samg7b5 samg7b5 commented May 18, 2020

Jazz scales (scales.py):

  • minor modes (harmonic and melodic)
  • bebop scales

Minor midi fixes:

  • zero velocity signifying a note-off event (may be the convention used in midi files generated by Lilypond)
  • a key->str(key) typing fix (I must have run into a TypeError at some point)

samg7b5 added 2 commits May 18, 2020 20:24
@samg7b5
Midi fixes
e872d04 
Midi fixes agreed from last PR
@samg7b5
Add jazz scales
347f297 
Add minor mode families, bebop scales
@samg7b5 samg7b5 mentioned this pull request May 18, 2020
Closed
@edudobay
Copy link
Collaborator

Hi @samg7b5, and sorry for the long delay! I was going to merge this but then I noticed your usage of TemporalNote() which does not exist. Where did this come from? Do you have any suggestion on what to do about this?

Meanwhile, I've cherry-picked your MIDI fix to the master branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samg7b5 @edudobay