Hotfix 3.1.6 (#2068)

[themerekat]

• Minor editor fix

• Remove head from editor due to causing more disruptions than benefits due to variations within portals central css stylings. Best to integrate head into new redesign of occurrence editor.

• Update hotfix version (3.1.6)

• closes [Bug] Re-linking image to a new occurrence does not re-generate tid in images table (the old tid remains) BioKIC/Symbiota#1954 Fixes use of hidden button and button submit value

Fix transfer taxa form so that action is submited in the request

• Fixing Login Form CSS closes Portal login box needs better alignment BioKIC/Symbiota#1975

Issue BioKIC#1975

Summary

input id value for email was "login" and css rule #login {float: right} was being applied to this accidently causing some odd behavior. Changed id of login so the collid wouldn't happen and bumped the width of the form so that it will display correctly.

• resolve merge conflict

• Occurrence Profile bugs

• Adjust editor permissions check so that it includes creator of general research collections (observerUid = active user)
• Avoid double sanitation of identifier and collector

• Update geolocate.php (Update geolocate.php BioKIC/Symbiota#1996)

Fixes minor typo that occurs in error message

• hotfix - protection

• If collid input is a number + single quote, assume it's an SQL Inject support and set value to 0, which returns nothing, rather than putting a load on the server

• Institution Sanitation issue

• Remove sanitation off outbound notes content to avoid interfering with embedded html tags that are added when this field is appended with GriSciColl info.
• Remove sanitation notes which were only meant to communicate to internal team when sanitation content was originally added. Resolves following issue, in part: [Bug] Sanitizing institution data harvested from GrSciColl breaks functionality BioKIC/Symbiota#1982

• API Annotation Bug

• Fix issue with missing recordID field from SQL statement definition

• added the changes to hotfix

• Bug adding image

• If user is null, user verification code incorrectly checks to see if there is a user with an empty string username or email. Thus, add code that skips checking user table if login details are an empty value
• Don't add empty strings to database. Keep them as null values.
• Comment out user verification check. Just test to make sure it's a number.

• remove associations changes

• Closes 2 tweaks to map interface: alphabetize & change wording BioKIC/Symbiota#2040 Sorts By Sciname within family (Closes #2040 Sorts By Sciname within family BioKIC/Symbiota#2052)

Issue BioKIC#2040

Summary

Adds extra sort conditions so that records are sorted by sciname after being storted by family.

• Closes [Bug] Global variable typos in GlossaryManager.php BioKIC/Symbiota#2049 Fixes typo on globals variable

Issues BioKIC#2049

Summary

Fixes typo for IMAGE_ROOT_PATH and IMAGE_ROOT_URL global variables. Note this will be overritten in the coming 3.2 changes with the multimedia changes so maybe it would be worth merging.

• Fix country synonyms, some U.S. states, add U.S. state abbreviations (Fix country synonyms, some U.S. states, add U.S. state abbreviations BioKIC/Symbiota#2059)

• Closes [bug] PHP warnings in lichen portal BioKIC/Symbiota#2064 Fixing String Number multiply

Issues BioKIC#2064

Summary

Adds as is_numeric check on 'page' request variable so that the $pageNumber variable is alwasys a number

• Update geolocate.php per Nelson's suggestion (Update geolocate.php to correct iframe error issue BioKIC/Symbiota#2066)

See BioKIC#1702 (comment)

• Update db_schema_patch-3.1.sql

• Explicitly set the index for omoccurrences.locality to a length of 100, thus avoid DB setting it to a default larger length that is beyond what is needed nor practical. Addresses issue: Missing key length for IX_occurrences_locality in omoccurrences BioKIC/Symbiota#2050

• removed arrow functions and union types

• replaced str_contains with str_pos