write a report regardless if leaks are present (gitleaks#758)

bryancowan · Dec 17, 2021 · 43ec224 · 43ec224
1 parent 36779df
commit 43ec224
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/report/json.go b/report/json.go
@@ -7,7 +7,7 @@ import (
 
 func writeJson(findings []Finding, w io.WriteCloser) error {
 	if len(findings) == 0 {
-		return nil
+		findings = []Finding{}
 	}
 	encoder := json.NewEncoder(w)
 	encoder.SetIndent("", " ")

diff --git a/report/json_test.go b/report/json_test.go
@@ -39,9 +39,8 @@ func TestWriteJSON(t *testing.T) {
 			}},
 		{
 
-			wantEmpty:      true,
 			testReportName: "empty",
-			expected:       filepath.Join(expectPath, "report", "this_should_not_exist.json"),
+			expected:       filepath.Join(expectPath, "report", "empty.json"),
 			findings:       []Finding{}},
 	}
 

diff --git a/report/report.go b/report/report.go
@@ -14,9 +14,6 @@ const (
 )
 
 func Write(findings []Finding, cfg config.Config, ext string, reportPath string) error {
-	if len(findings) == 0 {
-		return nil
-	}
 	file, err := os.Create(reportPath)
 	if err != nil {
 		return err

diff --git a/testdata/expected/report/empty.json b/testdata/expected/report/empty.json
@@ -0,0 +1 @@
+[]