Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit \lxSVG@closescope in reversion #2498

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

xworld21
Copy link
Contributor

Fix #2476. It doesn't fix --pictureimages in general: it only makes it compile something successfully. Unfortunately, the output is cropped the wrong way, but that's a different issue altogether.

@xworld21 xworld21 marked this pull request as ready for review January 25, 2025 19:14
@dginev
Copy link
Collaborator

dginev commented Jan 26, 2025

Sure. I guess we can motivate the empty reversion with \lxSVG@begingroup@ having an empty reversion.

@dginev dginev merged commit 70de862 into brucemiller:master Jan 26, 2025
13 checks passed
@xworld21 xworld21 deleted the lxsvg-closescope branch January 26, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\lxSVG@closescope leaks into reversion, breaks --pictureimages
2 participants