-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tikz cd #2325
Tikz cd #2325
Conversation
I was just discussing with arXiv three of our existing successful Tikz conversions, and did a quick test with this PR - linking to the significantly older ar5iv editions:
So, focusing on the one pgfplots case that regressed: it indeed works with the latexml master branch. Isolating a minimal regressing example: \documentclass{article}
\begin{filecontents}{coord.txt}
nc I_M_opt I_J I
1.000000 0.000000 0.000000 0.001190
2.000000 0.004133 0.003861 0.002870
3.000000 0.005510 0.007181 0.004562
\end{filecontents}
\usepackage{pgfplotstable}
\begin{document}
\begin{tikzpicture}
\begin{loglogaxis}[legend style={cells={align=left}}]
\pgfplotstableread{coord.txt}\mytable
\addplot[solid] table[x=nc,y=I] {\mytable};
\addlegendentry{legend}
\end{loglogaxis}
\end{tikzpicture}
\end{document} Edit: can confirm this was fixed by 5298bf8 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our arXiv sandboxes are looking healthy, and we can continue to improve post-release - tikz has a lot of terrain to test, e.g. #2326 .
I am bookkeeping the sandbox results for the v0.8.8 release here, results of this PR are in the 5th table from the top:
https://gist.github.com/dginev/abb72c989f4474a3a33300ed23ac6c86
I think the PR gets us another step closer to "faithful TeX interpretation", which is excellent. Looks good to merge.
* Do NOT bump ALIGN_STATE when digesting braces * But rather maintain ALIGN_STATE while 'scanning', ie. when reading in Gullet, being careful about unread tokens * Add two pgfmath functions defined by tikz-cd (axis_height, rule_thickness) * Add new binding for tikz-cd * pgfsys's alternative \halign needs the ALIGN_STATE adjustments, as well * Recognize and convert math nested within ltx:XMText/ltx:picture * Adjust placement of tikz picture (for tikz-cd) * Fix unread oversight
This PR provides a binding for
tikz-cd
, after fixing some infrastructure.The critical bug was that
ALIGN_STATE
which tracks{}
during scanning to enable or disable certain alignment tokens (&,\cr,...
) was being done too late (in Stomach rather than Gullet). It's easy to miss some corner cases, so some sandbox testing is warranted.This is a WiP since the resulting
svg
are displayed too low; there would seem to be one too many adjustments involvingpgf@pixminy
(?) , although other tikz pictures seem mostly correct.