Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass --no-as-needed to clang #108

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Don't pass --no-as-needed to clang #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,11 @@
list(APPEND ALL_WARNINGS -Wsuggest-override -Wno-int-in-bool-context)
endif()

if(CMAKE_COMPILER_IS_GNUCC)
if(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
# these flags are not known to clang
set(CMAKE_GCC_FLAGS "-Wl,--no-as-needed")
set(CMAKE_RDYNAMIC_FLAG "-rdynamic")
endif(CMAKE_COMPILER_IS_GNUCC)
endif()

if(COMPILE_WASM)
if(USE_THREADS)
Expand Down Expand Up @@ -568,7 +568,7 @@
endif(CUDA_FOUND)

else(COMPILE_CUDA)
message(WARNING "COMPILE_CUDA=off : Building only CPU version")

Check warning on line 571 in CMakeLists.txt

View workflow job for this annotation

GitHub Actions / Windows CPU-only 

COMPILE_CUDA=off : Building only CPU version
endif(COMPILE_CUDA)

# TODO: make compatible with older CUDA versions
Expand Down
Loading