Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable checking file name and erroring for shared gdrive files. #518

Open
wants to merge 1 commit into
base: horizon
Choose a base branch
from
Open

Disable checking file name and erroring for shared gdrive files. #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/web/js/gdrive-locators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,6 @@ define("cpo/gdrive-locators", [], function() {
// Shared GDrive locators require a refresh to be re-fetched
var sharedLocatorCache = {};
function makeSharedGDriveLocator(filename, id) {
function checkFileResponse(file, filename, restarter) {
var actualName = file.getName();
if(actualName !== filename) {
restarter.error(runtime.ffi.makeMessageException("Expected file with id " + id + " to have name " + filename + ", but its name was " + actualName));
}
}
function contentRequestFailure(failure) {
return "Could not load file with name " + filename;
}
Expand All @@ -192,8 +186,6 @@ define("cpo/gdrive-locators", [], function() {
restarter.error(runtime.ffi.makeMessageException(fileRequestFailure(failure, filename)));
});
var fileP = filesP.then(function(file) {
checkFileResponse(file, filename, restarter);
// checkFileResponse throws if there's an error
return file;
});
var contentsP = Q.all([fileP, fileP.then(function(file) {
Expand Down