Skip to content

Commit

Permalink
Merge pull request #1 from brooklyn-data/pr-checklist
Browse files Browse the repository at this point in the history
Create PR template for data modeling updates
  • Loading branch information
ayrenay authored May 20, 2020
2 parents f0ff379 + 780fc80 commit 9b046a7
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions pr_templates/dbt_modeling_pr.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
## Overview
_Summarize the goal of your work and what motivated it._

## Key changes
- _Describe major updates._

## Other notes
- _List open questions and other things your reviewer should know._

## Related links
- _List links to related ticket(s)._
- _(optional) Link to other files and resources, such as specific related reports in a BI tool._

## Checklist
- [ ] All models, whether directly changed by this PR or not, run successfully.
- [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md).
- [ ] Testing:
- [ ] All added/modified models and columns are documented and tested in `schema.yml` files.
- [ ] All tests pass. **OR**
_Check one:_
- [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR.
- [ ] This PR causes new test failures and there is a plan in place for addressing them.

0 comments on commit 9b046a7

Please sign in to comment.