-
Notifications
You must be signed in to change notification settings - Fork 59
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1 from brooklyn-data/pr-checklist
Create PR template for data modeling updates
- Loading branch information
Showing
1 changed file
with
22 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
## Overview | ||
_Summarize the goal of your work and what motivated it._ | ||
|
||
## Key changes | ||
- _Describe major updates._ | ||
|
||
## Other notes | ||
- _List open questions and other things your reviewer should know._ | ||
|
||
## Related links | ||
- _List links to related ticket(s)._ | ||
- _(optional) Link to other files and resources, such as specific related reports in a BI tool._ | ||
|
||
## Checklist | ||
- [ ] All models, whether directly changed by this PR or not, run successfully. | ||
- [ ] New code follows [dbt coding conventions](https://github.com/brooklyn-data/co/blob/master/dbt_coding_conventions.md) and [SQL style guide](https://github.com/brooklyn-data/co/blob/master/sql_style_guide.md). | ||
- [ ] Testing: | ||
- [ ] All added/modified models and columns are documented and tested in `schema.yml` files. | ||
- [ ] All tests pass. **OR** | ||
_Check one:_ | ||
- [ ] There are no new test failures, whether or not the existing model was intentionally changed for this PR. | ||
- [ ] This PR causes new test failures and there is a plan in place for addressing them. |