Full overhaul of the repository #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduction Android Material Components Migration to Kotlin Migration to AndroidX Android Architecture Navigation: mainly for Safe Arguments Switch to Fragment & Fragment ViewModel instead of single Activity Use of databinding Read Contacts Permission requester integrated Introduction Timber for logging Hilt dependency injection (for viewmodel) Sample App added to showcase the library Configure strings added to arguments Latest version of Android build tools and other dependencies
|
Excellent stuff Peter... thank you. I sadly have not had the time to work on this anymore and my primary development platform is no longer Android which makes it even harder! I've invited you as a collaborator on the project, please feel free to integrate this changes as you see fit :) |
|
Hi J,
thank you very much. I'm not yet up to speed on github and the library
build system (android-maven-gradle-plugin) so that will take some more time
to investigate.
Once I have the possibility I will look into this further and try to
prepare a new update! Thanks.
Kind regards,
Peter
…On Wed, 26 Aug 2020 at 21:42, J ***@***.***> wrote:
Excellent stuff Peter... thank you. I sadly have not had the time to work
on this anymore and my primary development platform is no longer Android
which makes it even harder! I've invited you as a collaborator on the
project, please feel free to integrate this changes as you see fit :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANE6PZFNWHQNEGDPK5TSD3SCTYKVANCNFSM4QLWJVYQ>
.
|
ispam
reviewed
Feb 7, 2021
| dest.writeTypedList(mPhoneNumbers) | ||
| } | ||
|
|
||
| companion object { |
There was a problem hiding this comment.
You can use @parcelize to avoid creating all this manually
ispam
reviewed
Feb 7, 2021
| dest.writeString(number) | ||
| } | ||
|
|
||
| companion object { |
ispam
reviewed
Feb 7, 2021
| import kotlin.properties.ReadOnlyProperty | ||
| import kotlin.reflect.KProperty | ||
|
|
||
| fun <T> Fragment.viewLifecycleLazy(initialise: () -> T): ReadOnlyProperty<Fragment, T> = object : ReadOnlyProperty<Fragment, T>, DefaultLifecycleObserver { |
ispam
reviewed
Feb 7, 2021
| @@ -0,0 +1,67 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <navigation xmlns:android="http://schemas.android.com/apk/res/android" | |||
ispam
approved these changes
Feb 7, 2021
|
Guys, I'm interested on contributing in this repo. @peterhav may I take this branch and solved conflicts? |
Hello, you're welcome to contribute if still interested? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the developer of this library,
I have been using this library in one of my Android applications and really appreciate it. Recently I have migrated all my sources to Android X and found this library to be the last dependency that was not yet using AndroidX.
After looking at the sources; I've decided to make several more improvements and ended up with the list below:
Updates
I've tried to keep the original code and interface in place where possible. Happy for you to decide if you want to use this or not.
Kind regards,
Peter